Bug 270020 - net/ooni-probe-cli: update 3.21.1 → 3.22.0
Summary: net/ooni-probe-cli: update 3.21.1 → 3.22.0
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vinícius Zavam
URL: https://github.com/ooni/probe-cli/rel...
Keywords:
Depends on: 272643
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-07 23:46 UTC by Älven
Modified: 2024-05-26 17:26 UTC (History)
1 user (show)

See Also:
egypcio: maintainer-feedback+


Attachments
270020___net_ooni-probe-cli.diff (1.85 KB, patch)
2023-09-02 14:31 UTC, Vinícius Zavam
no flags Details | Diff
270020___net_ooni-probe-cli.log (649.49 KB, text/plain)
2023-09-02 14:39 UTC, Vinícius Zavam
no flags Details
update to 3.21.1 (1.92 KB, patch)
2024-04-13 11:46 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Älven 2023-03-07 23:46:52 UTC

    
Comment 1 Vinícius Zavam freebsd_committer freebsd_triage 2023-05-21 16:56:19 UTC
ACK
Comment 2 Vinícius Zavam freebsd_committer freebsd_triage 2023-08-26 07:26:42 UTC
howdy! life just happened and this was put in a hold for a while -- gonna give a shot to get it updated over the upcoming days (aka weekend).

goal is definitely to get https://github.com/ooni/probe-cli/releases/tag/v3.18.1 working here.
Comment 3 Vinícius Zavam freebsd_committer freebsd_triage 2023-09-02 14:25:15 UTC
hello there! it seems we are currently blocked by some unsupported features in Go itself. please follow updates related to bug #272643 (I'm linking the issue here as well, just in case).

that's also affecting the build of a recent "oonimini"

using go121 doesn't seem to fix the issue for us.
Comment 4 Vinícius Zavam freebsd_committer freebsd_triage 2023-09-02 14:31:27 UTC
Created attachment 244589 [details]
270020___net_ooni-probe-cli.diff

sharing the current diff/patch which should give us v3.18.1.
Comment 5 Vinícius Zavam freebsd_committer freebsd_triage 2023-09-02 14:39:14 UTC
Created attachment 244590 [details]
270020___net_ooni-probe-cli.log

log from poudriere;
  * jail running latest 13R/amd64;

piece of upstream code related to the suspected blocker;
  * https://github.com/ooni/probe-cli/blob/v3.18.1/internal/netxlite/getaddrinfo_cgo.go
Comment 6 Vinícius Zavam freebsd_committer freebsd_triage 2023-09-02 14:41:41 UTC
tried to build it without CGO enabled, just in case; didn't work either :) fyi.
Comment 7 Älven 2023-11-04 12:49:10 UTC
Well, let's wait for upstream to fix it somehow. :)
Comment 8 Älven 2024-01-25 06:59:42 UTC
Initial support for Go 1.21

Community members asked us to add Go 1.21 support. It is now possible to compile OONI Probe using Go 1.21. Because Psiphon does not support Go 1.21 yet, when you're building using Go 1.21, it would not be possible to use Psiphon as a circumvention tunnel or to run the Psiphon experiment. (Psiphon should finish migrating to Go 1.21 soon, so OONI Probe 3.21 should have full Go 1.21 support.)
Comment 9 Rene Ladan freebsd_committer freebsd_triage 2024-04-13 11:42:37 UTC
Trying to build version 3.21.1 now
Comment 10 Rene Ladan freebsd_committer freebsd_triage 2024-04-13 11:44:15 UTC
Same problem with netxlite as before:

# github.com/ooni/probe-cli/v3/internal/netxlite
internal/netxlite/getaddrinfo_cgo.go:203:7: could not determine kind of name for C.AF_INET
internal/netxlite/getaddrinfo_cgo.go:207:7: could not determine kind of name for C.AF_INET6
internal/netxlite/getaddrinfo_cgo.go:141:20: could not determine kind of name for C.AF_UNSPEC
internal/netxlite/getaddrinfo_cgo.go:140:22: could not determine kind of name for C.SOCK_STREAM
Comment 11 Rene Ladan freebsd_committer freebsd_triage 2024-04-13 11:46:34 UTC
Created attachment 249949 [details]
update to 3.21.1
Comment 12 Rene Ladan freebsd_committer freebsd_triage 2024-04-21 12:11:14 UTC
(In reply to Rene Ladan from comment #11)

How about committing this patch, change the BROKEN message, and remove the deprecation of this port? If I understand correctly, the problem is in Go, not in this port.
Comment 13 Älven 2024-04-21 12:12:55 UTC
I'm all for it!
Comment 14 commit-hook freebsd_committer freebsd_triage 2024-04-22 20:50:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f2b44b3ae1c0c62d514fd2db5615314ac5884039

commit f2b44b3ae1c0c62d514fd2db5615314ac5884039
Author:     Rene Ladan <rene@FreeBSD.org>
AuthorDate: 2024-04-22 20:45:26 +0000
Commit:     Rene Ladan <rene@FreeBSD.org>
CommitDate: 2024-04-22 20:49:22 +0000

    net/ooni-probe-cli: update to 3.21.1, still BROKEN

    Unexpire the port, but it remains broken due to PR 272643.
    It now depends on the default Go version instead of the
    removed lang/go118

    PR:     270020

 net/ooni-probe-cli/Makefile | 11 ++++-------
 net/ooni-probe-cli/distinfo | 10 +++++-----
 2 files changed, 9 insertions(+), 12 deletions(-)