Created attachment 241574 [details] freeswitch: remove obsolete/unusable options This commit, https://cgit.freebsd.org/ports/commit/net/freeswitch/Makefile?id=b76fa3f75f739fbfafa3854200a96a5cd65c7604, removed the port's dependency on ImageMagick, but did not remove the OPTION that controlled whether the dependency was for the x11/nox11 flavor. This commit also removed the ALL_MODULES option, and all its associated Makefile variables. The recent bug #269482 reverted some of the changes to the Makefile, adding in a bunch of ALL_MODULES dependencies for a non-existent option. Some of the dependencies are clearly wrong, such as the one for python 2.7. Additionally, the vestigial X11 option is still not used elsewhere in the Makefile. As the ImageMagick dependency (and ALL was removed over 2 years ago with no reported bugs, I think it's safe to assume that the optional imagick freeswitch module isn't necessary. Will post a patch of the proposed change.
Created attachment 241575 [details] freeswitch: remove obsolete/unusable options This updated patch also removes the unused "extrapatch" file, which should have been removed when the ALL_MODULES option was removed two years ago. There is no way to trigger the port tree to use the patch via the ALL_MODULES_EXTRA_PATCHES conditional, as the ALL_MODULES option is undefined for freeswitch.