Bug 270991 - www/tinyproxy: The config file is installed into /usr/local/etc/tinyproxy.conf, but the application is looking in /usr/local/etc/tinyproxy/tinyproxy.conf
Summary: www/tinyproxy: The config file is installed into /usr/local/etc/tinyproxy.con...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-21 22:34 UTC by Yuri Victorovich
Modified: 2024-05-28 10:26 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch (981 bytes, patch)
2023-04-21 22:45 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2023-04-21 22:34:03 UTC 
$ pkg info -l tinyproxy
tinyproxy-1.11.1,1:
	/usr/local/etc/rc.d/tinyproxy
	/usr/local/etc/tinyproxy.conf.sample
	/usr/local/sbin/tinyproxy
	/usr/local/share/licenses/tinyproxy-1.11.1,1/GPLv2
	/usr/local/share/licenses/tinyproxy-1.11.1,1/LICENSE
	/usr/local/share/licenses/tinyproxy-1.11.1,1/catalog.mk
	/usr/local/share/man/man5/tinyproxy.conf.5.gz
	/usr/local/share/man/man8/tinyproxy.8.gz
	/usr/local/share/tinyproxy/debug.html
	/usr/local/share/tinyproxy/default.html
	/usr/local/share/tinyproxy/stats.html


$ tinyproxy
tinyproxy: Could not open config file "/usr/local/etc/tinyproxy/tinyproxy.conf".


The patch files/patch-etc-Makefile.in removes the sub-directory /usr/local/etc/tinyproxy, but the code is still looking for the file in that subdirectory.

Version: 1.11.1
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-04-21 22:45:11 UTC 
Created attachment 241645 [details]
patch
Comment 2 Herbert J. Skuhra 2024-05-14 06:44:13 UTC 
Maintainer timeout? Can anyone commit this change?
Comment 3 Herbert J. Skuhra 2024-05-14 07:07:27 UTC 
(In reply to Herbert J. Skuhra from comment #2)
I guess more changes are required (e.g. files/tinyproxy.in)
Comment 4 Herbert J. Skuhra 2024-05-14 08:36:49 UTC 
(In reply to Herbert J. Skuhra from comment #3)
Please ignore my previous comment. 

To resolve this issue the file src/Makefile.in must be patched:

diff --git a/www/tinyproxy/files/patch-src-Makefile.in b/www/tinyproxy/files/patch-src-Makefile.in
new file mode 100644
index 000000000000..abc609dd9d8a
--- /dev/null
+++ b/www/tinyproxy/files/patch-src-Makefile.in
@@ -0,0 +1,11 @@
+--- src/Makefile.in.orig       2024-05-14 10:08:57.559109000 +0200
++++ src/Makefile.in    2024-05-14 10:09:15.430240000 +0200
+@@ -307,7 +307,7 @@
+ top_build_prefix = @top_build_prefix@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+-pkgsysconfdir = $(sysconfdir)/$(PACKAGE)
++pkgsysconfdir = $(sysconfdir)
+ AM_CPPFLAGS = \
+       -DSYSCONFDIR=\"${pkgsysconfdir}\" \
+       -DLOCALSTATEDIR=\"${localstatedir}\"


Please see #278967.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-05-28 10:25:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bfe1afd57664689a425dec1401a1b9f423f8b00f

commit bfe1afd57664689a425dec1401a1b9f423f8b00f
Author:     Yuri Victorovich <yuri@freebsd.org>
AuthorDate: 2024-05-28 10:17:29 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-05-28 10:21:55 +0000

    www/tinyproxy: Fix default configuration file path

    - Bump PORTREVISION for package change

    It does not affect normal use (via rc script).

    PR:             270991
    Submitted by:   yuri

 www/tinyproxy/Makefile                          |  2 +-
 www/tinyproxy/files/patch-src-Makefile.in (new) | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-05-28 10:26:33 UTC 
Committed. Thanks!