Bug 271060 - databases/mariadb106-server does not build with ROCKSDB=on
Summary: databases/mariadb106-server does not build with ROCKSDB=on
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL: https://jira.mariadb.org/browse/MDEV-...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-25 06:56 UTC by Miroslav Lachman
Modified: 2023-04-27 11:38 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (brnrd)


Attachments
full Poudriere error log (68.10 KB, application/gzip)
2023-04-25 06:58 UTC, Miroslav Lachman
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Lachman 2023-04-25 06:56:38 UTC
We are building all our packages in Poudriere for a years. Today I was trying to rebuild all packages with new FreeBSD version 13.2 and quarterly branch 2023Q2 where MariaDB failed with the following error:

/wrkdirs/usr/ports/databases/mariadb106-server/work/mariadb-10.6.12/storage/rocksdb/./ut0counter.h:64:10: error: incompatible pointer to integer conversion assigning to 'size_t' (aka 'unsigned long') from 'pthread_t' (aka 'pthread *')
                        cpu = get_curr_thread_id();
                              ^~~~~~~~~~~~~~~~~~~~
/wrkdirs/usr/ports/databases/mariadb106-server/work/mariadb-10.6.12/storage/rocksdb/./ut0counter.h:34:30: note: expanded from macro 'get_curr_thread_id'
#define get_curr_thread_id() pthread_self()
                             ^~~~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.
*** Error code 1

Building of 10.6.12 on 12.x and previous quarterly 2023Q1 was OK so this is some regression on 13.2 or 2023Q2

We have non-default options:

---Begin OPTIONS List---
===> The following configuration options are available for mariadb106-server-10.6.12:
     CONNECT_EXTRA=off: Enable ODBC and XML in CONNECT engine
     DOCS=off: Build and/or install documentation
     WSREP=on: Build wsrep clustering
====> Optional page compression
     LZ4=on: LZ4 compression support
     LZO=on: LZO compression support
     SNAPPY=off: Snappy compression library support
====> Optional MariaDB storage engines
     COLUMNSTORE=off: Columnar storage egine (BETA)
     INNOBASE=on: InnoDB default engine
     MROONGA=off: Mroonga Full Text Search engine
     OQGRAPH=off: Open Query Graph Computation engine
     ROCKSDB=on: RocksDB LSM engine
     S3=off: S3 storage engine (Alpha)
     SPHINX=on: SphinxSE engine
     SPIDER=on: Partitioning and XA-transactions engine
====> Optional Mroonga features
     ZMQ=off: ZeroMQ support
     MSGPACK=off: MsgPack support
====> GSSAPI Security API support: you have to select exactly one of them
     GSSAPI_BASE=off: GSSAPI support via base system (needs Kerberos)
     GSSAPI_HEIMDAL=off: GSSAPI support via security/heimdal
     GSSAPI_MIT=off: GSSAPI support via security/krb5
     GSSAPI_NONE=on: Disable GSSAPI support
===> Use 'make config' to modify these settings
---End OPTIONS List---
Comment 1 Miroslav Lachman 2023-04-25 06:58:07 UTC
Created attachment 241730 [details]
full Poudriere error log
Comment 2 Mina Galić freebsd_triage 2023-04-25 07:02:07 UTC
this is a bug in upstream.
they need to sort out their types
Comment 3 Miroslav Lachman 2023-04-25 07:21:45 UTC
(In reply to Mina Galić from comment #2)
Is it reported upstream?
Comment 4 Mina Galić freebsd_triage 2023-04-25 09:00:46 UTC
it doesn't seem to be: https://jira.mariadb.org/issues/?jql=text%20~%20%22incompatible%20pointer%20to%20integer%20conversion%20assigning%20to%20%27size_t%27%20(aka%20%27unsigned%20long%27)%20from%20%27pthread_t%27%20(aka%20%27pthread%20*%27)%22

do you wanna do that: https://mariadb.com/kb/en/connection-string-in-mariadb-10-10/ (yes, that's the URL for MariaDB's knowledge base article on how "File a bug or feature request")

and please link their issue back to ours here
Comment 5 Mina Galić freebsd_triage 2023-04-25 09:04:51 UTC
there has been a related issue, https://jira.mariadb.org/browse/MDEV-23910 reported and fixed
Comment 6 Miroslav Lachman 2023-04-25 12:04:00 UTC
(In reply to Mina Galić from comment #4)
Thanks, I already reported some issues in MariaDB's JIRA (almost always without any progress for a long time - the last one is serious memory leak causing crashes). I will report this issue soon.
Comment 7 Mina Galić freebsd_triage 2023-04-25 12:51:26 UTC
if there's no reaction, we can patch our ports to add -Wno-int-conversion for ROCKSDB=on.
but: we'd be patching over a potential bug
Comment 8 Miroslav Lachman 2023-04-25 23:26:24 UTC
(In reply to Mina Galić from comment #4)
Reported upstream https://jira.mariadb.org/browse/MDEV-31129