Bug 272933 - net/sakisafecli: Update to 2.5.1
Summary: net/sakisafecli: Update to 2.5.1
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://git.suragu.net/svragv/sakisaf...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-04 09:10 UTC by diego
Modified: 2024-05-02 11:46 UTC (History)
3 users (show)

See Also:


Attachments
Patch for net/sakisafecli/Makefile (1008 bytes, patch)
2023-08-04 09:10 UTC, diego
no flags Details | Diff
New attachment (1.29 KB, patch)
2023-08-04 16:11 UTC, diego
no flags Details | Diff
Sugestion update patch (1.81 KB, patch)
2024-04-27 11:30 UTC, Nuno Teixeira
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description diego 2023-08-04 09:10:04 UTC
Created attachment 243834 [details]
Patch for net/sakisafecli/Makefile

I did not have any computer with FreeBSD installed for a long of time so I did not updated the port. Now i have a computer with freebsd installed so i updated the port. This new version of sakisafecli just solves bugs.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2023-08-04 13:43:23 UTC
(In reply to qorg11 from comment #0)
Thanks for the patch (and congratulations for your FreeBSD machine). Can you also include the distfile checksum in the distinfo file? Also, if possible, please generate the patch with `diff -ruN`, `git diff` or `git format-patch` (preferred).
Comment 2 diego 2023-08-04 16:11:42 UTC
Created attachment 243840 [details]
New attachment
Comment 3 diego 2023-08-04 16:12:16 UTC
The checksum is cdc9d795658fb0a703a360f045e148c2aea5b563ef0428abe226fc890af56a02
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-07 06:13:51 UTC
(In reply to qorg11 from comment #3)
Have a look at this: https://docs.freebsd.org/en/books/porters-handbook/book/#porting-checksum
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-27 08:42:13 UTC
I'm getting timeout on https://git.suragu.net/svragv/sakisafe

Is upstream still available?

Thanks
Comment 6 diego 2024-04-27 10:48:02 UTC
Hello, yes I have updated the DNS record of git.suragu.net ^^
dynamic IPs are fun.

There is a mirror in github: https://github.com/rfc-2549/sakisafe but suragu.net git instance should be working now

thanks for reporting
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-27 10:56:29 UTC
(In reply to qorg11 from comment #6)

Working now. thanks
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-27 11:30:32 UTC
Created attachment 250258 [details]
Sugestion update patch

- Update MASTER_SITES
- Add WWW entry
- Define LICENSE_FILE
- Use PLIST_FILES instead of pkg-plist due to small list < 5 entries
- Pet portlint, portclippy and portfmt

Run `git apply /path/to/patch` and test.
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-27 11:33:41 UTC
Previous MASTER_SITES url offered a static tarball and updated one don't.

While it's working with auto-generated tarball v<version>.tar.gz one, it possible, create a release asset for it.

Thanks
Comment 10 diego 2024-04-27 11:45:03 UTC
Hello,

I have created the release asset for v2.5.1: https://git.suragu.net/svragv/sakisafe/releases

regards
Comment 11 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-27 11:56:15 UTC
(In reply to diego from comment #10)

But it misses a release tarball. Only dynamic generated v2.5.1.{zip,tar.gz} available.
Comment 12 Nuno Teixeira freebsd_committer freebsd_triage 2024-05-01 15:04:06 UTC
Any progress on this?

Also I'm thinking that getting disfile this way is wrong:

MASTER_SITES=	https://git.suragu.net/svragv/sakisafe/archive/
DISTNAME=	v${DISTVERSION}${EXTRACT_SUFFIX}

If we need to use auto-generated tarballs, similar USE_GITHUB should be used.
Comment 13 diego 2024-05-02 11:40:24 UTC
Hi,

You want me to provide binaries (for FreeBSD) for the software or just generate a tarball with the source code?

thanks :)
Comment 14 Nuno Teixeira freebsd_committer freebsd_triage 2024-05-02 11:46:20 UTC
(In reply to diego from comment #13)

src tarball please, like https://github.com/jordansissel/xdotool/releases/tag/v3.20211022.1

This way we could use MASTER_SITES instead of using USE_GITHUB way.