Bug 273680 - games/libretro-px68k: Fails to build with GCC 13: error: expected identifier before '__is_convertible'
Summary: games/libretro-px68k: Fails to build with GCC 13: error: expected identifier ...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lorenzo Salvadore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-10 07:36 UTC by Lorenzo Salvadore
Modified: 2023-11-18 11:49 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2023-09-10 07:36:27 UTC 
This bug report blocks the update of GCC_DEFAULT to 13. This webpage can help finding ta fix: https://gcc.gnu.org/gcc-13/porting_to.html

g++13 -c -ofmgen/file.o fmgen/file.cpp -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc13  -stdlib=libc++ -Wl,-rpath=/usr/local/lib/gcc13  -g -O2  -fno-merge-constants -D__LINUX__ -DNO_MERCURY -DPX68K_VERSION=\"0.15+\" -DGIT_VERSION=\"" "\" -DHAVE_C68K -O2 -ffast-math -fomit-frame-pointer -I. -I./libretro-common/include -I./libretro -I./x68k -I./fmgen -I./win32api -DC68K_NO_JUMP_TABLE -D__LIBRETRO__   -fPIC  -fpermissive
g++13 -c -ofmgen/fmg_wrap.o fmgen/fmg_wrap.cpp -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc13  -stdlib=libc++ -Wl,-rpath=/usr/local/lib/gcc13  -g -O2  -fno-merge-constants -D__LINUX__ -DNO_MERCURY -DPX68K_VERSION=\"0.15+\" -DGIT_VERSION=\"" "\" -DHAVE_C68K -O2 -ffast-math -fomit-frame-pointer -I. -I./libretro-common/include -I./libretro -I./x68k -I./fmgen -I./win32api -DC68K_NO_JUMP_TABLE -D__LIBRETRO__   -fPIC  -fpermissive
g++13 -c -ofmgen/fmgen.o fmgen/fmgen.cpp -O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc13  -stdlib=libc++ -Wl,-rpath=/usr/local/lib/gcc13  -g -O2  -fno-merge-constants -D__LINUX__ -DNO_MERCURY -DPX68K_VERSION=\"0.15+\" -DGIT_VERSION=\"" "\" -DHAVE_C68K -O2 -ffast-math -fomit-frame-pointer -I. -I./libretro-common/include -I./libretro -I./x68k -I./fmgen -I./win32api -DC68K_NO_JUMP_TABLE -D__LIBRETRO__   -fPIC  -fpermissive
In file included from /usr/include/c++/v1/math.h:309,
                 from fmgen/headers.h:10,
                 from fmgen/file.cpp:5:
/usr/include/c++/v1/type_traits:1770:8: error: expected identifier before '__is_convertible'
 1770 | struct __is_convertible
      |        ^~~~~~~~~~~~~~~~

Full log: https://pkg-status.freebsd.org/package18/data/124amd64-default-foo/2023-09-06_17h55m19s/logs/errors/libretro-px68k-0.20220311_1.log

There are other bugs similar to this one, such as bug #273671 or bug #273674.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-11-18 11:48:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e832b23c83eba87344de69fb8b575d87f32efa40

commit e832b23c83eba87344de69fb8b575d87f32efa40
Author:     Lorenzo Salvadore <salvadore@FreeBSD.org>
AuthorDate: 2023-11-18 11:32:43 +0000
Commit:     Lorenzo Salvadore <salvadore@FreeBSD.org>
CommitDate: 2023-11-18 11:48:03 +0000

    games/libretro-px68k: Drop GCC requirement

    This helps getting GCC_DEFAULT updates getting forward.

    PR:             273680

 games/libretro-px68k/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 Lorenzo Salvadore freebsd_committer freebsd_triage 2023-11-18 11:49:31 UTC 
The port does not depend on GCC any more. Remove the block for GCC_DEFAULT update.