Bug 274761 - www/libnghttp3: Update to 1.3.0
Summary: www/libnghttp3: Update to 1.3.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://github.com/ngtcp2/nghttp3/rel...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-27 22:37 UTC by Daniel Engberg
Modified: 2024-06-06 21:57 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for libnghttp3 (2.11 KB, patch)
2023-10-27 22:37 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libnghttp3 v2 (2.45 KB, patch)
2023-12-04 19:41 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libnghttp3 v3 (2.43 KB, patch)
2024-02-20 18:47 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libnghttp3 v4 (2.41 KB, patch)
2024-05-11 05:57 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-10-27 22:37:12 UTC 
Created attachment 245930 [details]
Patch for libnghttp3

* Switch to CMake for faster builds, it also additionally cleans up the port Makefile and removes the need for additional patching
* Remove C++17 requirement, only C++14 is required
* C++14 or C1++17 are default for all compilers we have in tree or base so no need to add CXXFLAGS
* Rearrange Makefile to follow Porters Handbook more closely and for readability

Compile tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist)
Poudriere testport OK 12.4-RELEASE (amd64)
Poudriere testport OK 13.2-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-12-04 19:41:04 UTC 
Created attachment 246780 [details]
Patch for libnghttp3 v2
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-02-20 18:47:34 UTC 
Created attachment 248647 [details]
Patch for libnghttp3 v3

Enable "make test"
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-05-11 05:57:10 UTC 
Created attachment 250581 [details]
Patch for libnghttp3 v4

* Switch to CMake for faster builds
* Remove C++ requirements, we don't build anything that's written in C++
* Rearrange Makefile to follow Porters Handbook more closely and for readability
* Enable "make test"

Compile and runtime tested on FreeBSD 14.0-RELEASE (amd64) (make, make check-plist, make test)
Poudriere testport OK 13.2-RELEASE (amd64)
Poudriere testport OK 14.0-RELEASE (amd64)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-06-06 19:09:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e670e294551e70e244f06997d37957680e955fb5

commit e670e294551e70e244f06997d37957680e955fb5
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-06-05 19:54:00 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-06-06 19:05:47 +0000

    www/libnghttp3: Improve port

    * Switch to CMake for faster builds
    * Remove C++ requirements, we don't build anything that's written in C++
    * Rearrange Makefile to follow Porters Handbook more closely and for readability
    * Enable "make test"

    PR:             274761
    Approved by:    portmgr (maintainer timeout, 3+ weeks)

 www/libnghttp3/Makefile                       | 16 ++++++++--------
 www/libnghttp3/distinfo                       |  2 +-
 www/libnghttp3/files/patch-Makefile.in (gone) | 14 --------------
 3 files changed, 9 insertions(+), 23 deletions(-)
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-06-06 20:43:44 UTC 
As I said in other PR, I won't use cmake for such tiny library.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-06-06 21:57:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7ca6cad1091a2ca7e636e31af3005deaf2c0c552

commit 7ca6cad1091a2ca7e636e31af3005deaf2c0c552
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-06-06 21:55:58 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-06-06 21:56:33 +0000

    www/libnghttp3: Remove USES=compiler:c++17-lang

    PR:             274761
    Reported by:    diizzy

 www/libnghttp3/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)