Bug 276507 - [PATCH] x11/ly: set login class
Summary: [PATCH] x11/ly: set login class
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-21 20:53 UTC by Robin Haberkorn
Modified: 2024-01-21 21:15 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bapt)

Attachments
Ports tree patch (3.01 KB, patch)
2024-01-21 20:53 UTC, Robin Haberkorn 		no flags Details | Diff
Patch ontop of the Ly repo (with all current FreeBSD patches) (1.35 KB, patch)
2024-01-21 20:56 UTC, Robin Haberkorn 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Haberkorn 2024-01-21 20:53:38 UTC 
Created attachment 247825 [details]
Ports tree patch

Ly logins where not setting the login class correctly (as established by /etc/login.conf and chpass).

This is fixed by this patch, which calls setusercontext() instead of setuid() and setgid().

I also opened an upstream ticket for this issue, but so far got no response (https://github.com/fairyglade/ly/issues/572). It's questionable whether all of the FreeBSD-specific stuff will ever be upstreamed. I also do not see who is responsible for the project at all.

I attached a ports tree patch. It applies both on main and 2024Q1.
Comment 1 Robin Haberkorn 2024-01-21 20:56:26 UTC 
Created attachment 247826 [details]
Patch ontop of the Ly repo (with all current FreeBSD patches)
Comment 2 Robin Haberkorn 2024-01-21 21:15:13 UTC 
Who is responsible for patch files being managed as they are right now, ie. having one patch per touched source file? Is there any kind of sane reason to do it the way FreeBSD does it right now? Where can I read about it?
It makes working with changes really cumbersome.

Everybody else uses ordered patch series where each patch corresponds to one feature or bug.