Bug 278748 - audio/py-speechrecognition: Convert post-patch to EXTRACT_AFTER_ARGS
Summary: audio/py-speechrecognition: Convert post-patch to EXTRACT_AFTER_ARGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 18:44 UTC by Daniel Engberg
Modified: 2024-05-28 13:58 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for py-speechrecognition (475 bytes, patch)
2024-05-04 18:44 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 18:44:15 UTC 
Created attachment 250384 [details]
Patch for py-speechrecognition

Saves I/O by not extracting files

Poudriere bulk OK
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-05-22 12:54:21 UTC 
I must say that I do not like this idea. And you have to put hardcoded "--no-same-owner --no-same-permissions" to EXTRACT_AFTER_ARGS, rather than EXTRACT_AFTER_ARGS+=...
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-28 10:25:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a38c23598e29c78a6fa0eb5b61c8ca8ffe1c9850

commit a38c23598e29c78a6fa0eb5b61c8ca8ffe1c9850
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-05-28 10:02:51 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-05-28 10:21:55 +0000

    audio/py-speechrecognition: Add EXTRACT_AFTER_ARGS

    PR:             278748
    Reported by:    diizzy

 audio/py-speechrecognition/Makefile | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-05-28 10:26:34 UTC 
Committed. Thanks!
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-05-28 13:58:20 UTC 
In this case, it would be great if we have something like "EXTRACT_EXCLUDE=foo bar blahblah" so that we do not have to hardcoded "--no-same-owner --no-same-permissions".