Bug 278775 - audio/id3lib: Switch to maintained fork and latest commit
Summary: audio/id3lib: Switch to maintained fork and latest commit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://github.com/thekhalifa/id3lib
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-05 09:00 UTC by Daniel Engberg
Modified: 2024-05-29 00:00 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch for id3lib (11.87 KB, patch)
2024-05-05 09:00 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 09:00:08 UTC 
Created attachment 250415 [details]
Patch for id3lib

It's not perfect but it cleans up our port significantly

Compile tested on FreeBSD 14.0-RELEASE (amd64) (make, make check-plist)
Poudriere testport OK 14.0-RELEASE (amd64)
Poudriere testport OK 13.2-RELEASE (amd64)

Tested with following consumers in 13.2-RELEASE (amd64) using Poudriere:
audio/easytag
audio/grip
audio/id3v2
audio/kwave
audio/ripperx
audio/squash
sysutils/mtpfs
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-28 23:58:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9519e493aa53a22aa64a8ff219932f1c1cf21997

commit 9519e493aa53a22aa64a8ff219932f1c1cf21997
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-05-28 23:57:55 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-05-28 23:57:55 +0000

    audio/id3lib: Change to a fork and update to newer snapshot

    - Update WWW

    Changes:        https://github.com/thekhalifa/id3lib/commits/master
    PR:             278775
    Reported by:    diizzy

 audio/id3lib/Makefile                              | 20 +++++----
 audio/id3lib/distinfo                              |  5 ++-
 audio/id3lib/files/patch-CVE-2007-4460 (gone)      | 49 ----------------------
 audio/id3lib/files/patch-Makefile.in (gone)        | 13 ------
 audio/id3lib/files/patch-configure (gone)          | 38 -----------------
 .../files/patch-examples-demo_convert.cpp (gone)   | 11 -----
 .../files/patch-examples-demo_copy.cpp (gone)      | 11 -----
 .../files/patch-examples-demo_info.cpp (gone)      | 11 -----
 .../files/patch-examples-demo_tag.cpp (gone)       | 11 -----
 .../files/patch-include-id3-globals.h (gone)       | 11 -----
 .../patch-include-id3-id3lib_strings.h (gone)      | 10 -----
 .../files/patch-include-id3-writers.h (gone)       | 10 -----
 audio/id3lib/files/patch-src-CMakeLists.txt (new)  |  9 ++++
 audio/id3lib/files/patch-src-io_helpers.cpp (gone) | 14 -------
 audio/id3lib/files/patch-src-mp3_parse.cpp (gone)  | 11 -----
 audio/id3lib/pkg-plist                             | 13 ++++--
 16 files changed, 33 insertions(+), 214 deletions(-)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-05-29 00:00:00 UTC 
Committed. Thanks!