Bug 278875 - graphics/shotwell fails to install with face detection disabled due to pkg-plist issue
Summary: graphics/shotwell fails to install with face detection disabled due to pkg-pl...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Christoph Moench-Tegeder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-09 16:41 UTC by russo
Modified: 2024-05-11 18:58 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cmt)


Attachments
Patch to fix shotwell pkg-plist when face detection is off (1.63 KB, patch)
2024-05-09 16:41 UTC, russo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description russo 2024-05-09 16:41:06 UTC
Created attachment 250552 [details]
Patch to fix shotwell pkg-plist when face detection is off

As of commit 54f51b39, two files that are only created when face detection is enabled are unconditionally included in pkg-plist.

The result is a failure to install due to missing file in the stage directory:

-----
pkg-static: Unable to access file /usr/ports/graphics/shotwell/work/stage/usr/local/share/dbus-1/services/org.gnome.Shotwell.Faces1.service:No such file or directory
pkg-static: Unable to access file /usr/ports/graphics/shotwell/work/stage/usr/local/share/shotwell/facedetect/deploy.prototxt:No such file or directory
-----

These lines in pkg-plist should be prefaced with %%FACED%%.  The attached patch fixes that.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-11 18:43:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b88290c40e3cb72653cfb33093bea7ec0c54e37d

commit b88290c40e3cb72653cfb33093bea7ec0c54e37d
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2024-05-11 18:40:08 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2024-05-11 18:40:08 +0000

    graphics/shotwell: fix plist with non-default options

    PR:             278875
    Submitted by:   Tom Russo

 graphics/shotwell/pkg-plist | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)