I was notified of the issue in several bugs, the last time was in bug 197605 comment 4. It'd be nice to have one of the following: - maintainer-approval permissions fixed or special-cased - editbugs is granted more freely like on other installations (e.g. Mozilla) - Phabricator's priority for non-committers access is raised - Bugzilla gains more granular review system Steps to reproduce: 1/ Find a port maintained by non-committer 2/ Submit a patch either to an existing bug or a new one 3/ Request maintainer-approval for the patch What happened: 4/ Maintainer (or any requestee) is not allowed to set flags on attachments not owned by himself/herself 5/ Maintainer comments on the status of approval instead What should have happend: 4/ Maintainer sets the flag to either `+' (accepted) or `-' (rejected)
(In reply to Jan Beich from comment #0) > I was notified of the issue in several bugs, the last time was in bug 197605 > comment 4. It'd be nice to have one of the following: > - maintainer-approval permissions fixed or special-cased We'll check this. > - editbugs is granted more freely like on other installations (e.g. Mozilla) This is far too unspecific. What fields to non-committers need to have access to to modify (if there are others, please create a separate PR)? > - Phabricator's priority for non-committers access is raised This is something, the phabricator admins have to deal with. > - Bugzilla gains more granular review system Can you be more specific on what you have in mind in a separate PR?
I filed an upstream bug for Bugzilla at https://bugzilla.mozilla.org/show_bug.cgi?id=1136039. A local fix for our installation will be rolled out with the next update.
The fix has been rolled out - the approvals should be editable by all users now.