files/patch-filter-subtitler-load_font.c needs to be removed from multimedia/transcode as it is causing builds to fail if the FREETYPE option is enabled.
Does this change need to be MFH'd?
I'm thinking it should, but it might depend on where the freetype port is installing ftglyph.h. I'm assuming that when the patch was submitted 2 years ago, the port was installing it to PREFIX/include/freetype2/freetype2, but now it installs it to PREFIX/include/freetype2/freetype instead.
I am not seeing the build fail with FREETYPE enabled in poudriere. My options list looks like this: ---Begin OPTIONS List--- ===> The following configuration options are available for transcode-1.1.7_25: A52=off: AC-3 support via liba52 BKTR=off: Bktr capture card support DOCS=on: Build and/or install documentation DV=off: Quasar DV video codec support (libdv) DVDREAD=on: Libdvdread support FAAC=off: FAAC AAC encoder support FREETYPE=on: TrueType font rendering support ICONV=on: Encoding conversion support via iconv IMAGEMAGICK=off: ImageMagick image processing support JPEG=on: JPEG image format support LAME=on: LAME MP3 audio encoder support LIBXML2=off: XML parser support via libxml2 LZO=off: LZO compression support MJPEGTOOLS=off: MJPEG Tools support MPEG2=off: MPEG-2 video support via libmpeg2 OGG=off: Ogg media format support OPTIMIZED_CFLAGS=off: Use extra compiler optimizations POSTPROC=off: Libpostproc support QUICKTIME=off: QuickTime media support SDL=off: Simple Direct Media Layer support THEORA=off: Ogg Theora video codec support V4L=off: Video 4 Linux support VORBIS=off: Ogg Vorbis audio codec support X11=off: X11 (graphics) support X264=off: H.264 video codec support via x264 XVID=off: Xvid MPEG-4 video codec support ===> Use 'make config' to modify these settings ---End OPTIONS List--- Thoughts?
For some time, multimedia/transcode had been failing for me in poudriere, but succeeding using portmaster. (I use portmaster for the ports on my laptop & build machine (itself), and run poudriere on the build machine to build all the packages installed on my "production" machines.) Options for poudriere: freebeast(10.2-S)[5] cat !$ cat multimedia_transcode/options # This file is auto-generated by 'make config'. # Options for transcode-1.1.7_17 _OPTIONS_READ=transcode-1.1.7_17 _FILE_COMPLETE_OPTIONS_LIST=DOCS OPTIMIZED_CFLAGS X11 MPEG2 BKTR POSTPROC FREETYPE LAME XVID X264 OGG VORBIS THEORA DVDREAD DV QUICKTIME LZO A52 FAAC LIBXML2 MJPEGTOOLS SDL IMAGEMAGICK JPEG ICONV V4L OPTIONS_FILE_SET+=DOCS OPTIONS_FILE_SET+=OPTIMIZED_CFLAGS OPTIONS_FILE_SET+=X11 OPTIONS_FILE_SET+=MPEG2 OPTIONS_FILE_UNSET+=BKTR OPTIONS_FILE_UNSET+=POSTPROC OPTIONS_FILE_SET+=FREETYPE OPTIONS_FILE_SET+=LAME OPTIONS_FILE_SET+=XVID OPTIONS_FILE_SET+=X264 OPTIONS_FILE_SET+=OGG OPTIONS_FILE_SET+=VORBIS OPTIONS_FILE_UNSET+=THEORA OPTIONS_FILE_SET+=DVDREAD OPTIONS_FILE_UNSET+=DV OPTIONS_FILE_SET+=QUICKTIME OPTIONS_FILE_UNSET+=LZO OPTIONS_FILE_SET+=A52 OPTIONS_FILE_UNSET+=FAAC OPTIONS_FILE_SET+=LIBXML2 OPTIONS_FILE_UNSET+=MJPEGTOOLS OPTIONS_FILE_SET+=SDL OPTIONS_FILE_SET+=IMAGEMAGICK OPTIONS_FILE_SET+=JPEG OPTIONS_FILE_SET+=ICONV OPTIONS_FILE_SET+=V4L freebeast(10.2-S)[6] This morning, I was directed to this PR; I tested by removing files/patch-filter-subtitler-load_font.c (on my laptop before the daily port-rebuild), and the port built successfully.
From looking at the revisions on print/freetype2's pkg-plist, it appears that the break happened after the update of freetype to 2.6.2 (svn revision 403474). That apparently changed the directory structure of how freetype is installed.
I have the same issue with poudriere builds since about the time that freetype change to 2.6.2 . My poudriere options file: # This file is auto-generated by 'make config'. # Options for transcode-1.1.7_23 _OPTIONS_READ=transcode-1.1.7_23 _FILE_COMPLETE_OPTIONS_LIST=A52 BKTR DOCS DV DVDREAD FAAC FREETYPE ICONV IMAGEMAGICK JPEG LAME LIBXML2 LZO MJPEGTOOLS MPEG2 OGG OPTIMIZED_CFLAGS POSTPROC QUICKTIME SDL THEORA V4L VORBIS X11 X264 XVID OPTIONS_FILE_SET+=A52 OPTIONS_FILE_UNSET+=BKTR OPTIONS_FILE_SET+=DOCS OPTIONS_FILE_UNSET+=DV OPTIONS_FILE_SET+=DVDREAD OPTIONS_FILE_SET+=FAAC OPTIONS_FILE_SET+=FREETYPE OPTIONS_FILE_SET+=ICONV OPTIONS_FILE_SET+=IMAGEMAGICK OPTIONS_FILE_SET+=JPEG OPTIONS_FILE_SET+=LAME OPTIONS_FILE_UNSET+=LIBXML2 OPTIONS_FILE_UNSET+=LZO OPTIONS_FILE_UNSET+=MJPEGTOOLS OPTIONS_FILE_SET+=MPEG2 OPTIONS_FILE_SET+=OGG OPTIONS_FILE_SET+=OPTIMIZED_CFLAGS OPTIONS_FILE_UNSET+=POSTPROC OPTIONS_FILE_UNSET+=QUICKTIME OPTIONS_FILE_UNSET+=SDL OPTIONS_FILE_SET+=THEORA OPTIONS_FILE_UNSET+=V4L OPTIONS_FILE_SET+=VORBIS OPTIONS_FILE_SET+=X11 OPTIONS_FILE_SET+=X264 OPTIONS_FILE_SET+=XVID Removing that patch file and rebuild fixes the issue for me as well.
A commit references this bug: Author: brd Date: Fri Jan 8 00:01:54 UTC 2016 New revision: 405492 URL: https://svnweb.freebsd.org/changeset/ports/405492 Log: Remove stale freetype patch that is breaking build PR: 205711 Submitted by: cyberbotx@cyberbotx.com Approved by: bdrewery MFH: 2016Q1 Changes: head/multimedia/transcode/files/patch-filter-subtitler-load_font.c
Removed, sorry for the delay.
A commit references this bug: Author: brd Date: Fri Jan 8 16:44:10 UTC 2016 New revision: 405568 URL: https://svnweb.freebsd.org/changeset/ports/405568 Log: MFHL r405492. Remove stale freetype patch that is breaking build PR: 205711 Submitted by: cyberbotx@cyberbotx.com (mentor) Approved by: bdrewery (mentor) Approved by: ports-secteam (miwi) Changes: _U branches/2016Q1/ branches/2016Q1/multimedia/transcode/files/patch-filter-subtitler-load_font.c