Bug 228543 - Remove kld from CATEGORIES if USES=kmod is defined
Summary: Remove kld from CATEGORIES if USES=kmod is defined
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2018-05-27 12:18 UTC by Mateusz Piotrowski
Modified: 2018-07-20 09:31 UTC (History)
1 user (show)

See Also:

Attachments
Patch removing explicit kld from CATEGORIES (1.23 KB, patch)
2018-05-27 12:18 UTC, Mateusz Piotrowski 		no flags Details | Diff
Patch removing explicit kld from CATEGORIES (revision: 1) (2.34 KB, patch)
2018-05-27 12:20 UTC, Mateusz Piotrowski 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2018-05-27 12:18:21 UTC 
Created attachment 193761 [details]
Patch removing explicit kld from CATEGORIES

This patch removes "kld" from CATEGORIES if USES is set to "kmod" because according to Porter's Handbook:

> (5.3.3. Choosing the Right Category)
> Ports installing loadable kernel modules also have the virtual category 
> kld in their CATEGORIES line. This is one of the things handled 
> automatically by adding USES=kmod.
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-05-27 12:20:36 UTC 
Created attachment 193762 [details]
Patch removing explicit kld from CATEGORIES (revision: 1)

Change to the previous patch: patch 3 more ports.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2018-07-20 01:03:28 UTC 
Differential revision: https://reviews.freebsd.org/D16359
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-07-20 09:31:00 UTC 
A commit references this bug:

Author: 0mp
Date: Fri Jul 20 09:30:01 UTC 2018
New revision: 474998
URL: https://svnweb.freebsd.org/changeset/ports/474998

Log:
  Remove redundant kld from CATEGORIES if a port uses kmod.

  "USES=kmod" already adds kld to CATEGORIES so it is unnecessary to set
  CATEGORIES to kld explicitly.

  PR:		228543
  Reviewed by:	krion (mentor)
  Approved by:	krion (mentor)
  Differential Revision:	https://reviews.freebsd.org/D16359

Changes:
  head/graphics/drm-next-kmod/Makefile
  head/graphics/drm-stable-kmod/Makefile
  head/graphics/gpu-firmware-kmod/Makefile
  head/multimedia/pwcbsd/Makefile
  head/net/userfw/Makefile
  head/sysutils/scprotect/Makefile