Bug 255031 - net-mgmt/nagios-check_clamav: add options for plugins
Summary: net-mgmt/nagios-check_clamav: add options for plugins
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Zsolt Udvari
URL: https://www.freshports.org/net-mgmt/n...
Keywords: feature
Depends on:
Blocks:
 
Reported: 2021-04-13 10:41 UTC by Krzysztof
Modified: 2024-05-12 17:32 UTC (History)
3 users (show)

See Also:
ports: maintainer-feedback+

Attachments
check_clamav patch (1.16 KB, patch)
2021-04-13 10:41 UTC, Krzysztof 		ports: maintainer-approval+
Details | Diff
poudriere testport log (36.68 KB, text/plain)
2021-04-13 10:42 UTC, Krzysztof 		no flags Details
update patch (1.40 KB, patch)
2024-03-22 15:04 UTC, Krzysztof 		ports: maintainer-approval+
Details | Diff
poudriere testport log (38.09 KB, text/plain)
2024-03-22 15:05 UTC, Krzysztof 		no flags Details
update patch (1.44 KB, patch)
2024-04-30 08:23 UTC, Krzysztof 		ports: maintainer-approval+
Details | Diff
patch to update the port (1.59 KB, patch)
2024-05-02 07:40 UTC, Krzysztof 		ports: maintainer-approval+
Details | Diff
patch to update the port (1.53 KB, patch)
2024-05-05 07:08 UTC, Krzysztof 		ports: maintainer-approval+
Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof 2021-04-13 10:41:43 UTC 
Created attachment 224077 [details]
check_clamav patch

net-mgmt/nagios-check_clamav is using nagios-plugins as dependency. I've made a patch similiar to net-mgmt/nrpe3 which allows choose between nagios-plugins and monitoring-plugins.

Also I'm attaching poudriere log from testport.

I did not changed maintainer addres but it is possible that I will be a new one.
Comment 1 Krzysztof 2021-04-13 10:42:13 UTC 
Created attachment 224078 [details]
poudriere testport log
Comment 2 Krzysztof 2022-11-20 21:31:58 UTC 
Comment on attachment 224077 [details]
check_clamav patch

it was 18 months ago so can we set maintainer-approval?
Comment 3 Krzysztof 2023-12-30 09:24:32 UTC 
Is it possible to commit update? I can see that this was "stopped" for almost a year :-(((
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2024-02-10 00:06:34 UTC 
There is no SSL option, please fix.
Comment 5 Krzysztof 2024-03-22 15:04:36 UTC 
Created attachment 249400 [details]
update patch

New version of patch. I've also changed MASTER_SITES as original is not working anymore.
Comment 6 Krzysztof 2024-03-22 15:05:08 UTC 
Created attachment 249401 [details]
poudriere testport log

tesport log from poudriere
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-04-27 18:03:01 UTC 
Could you please check 'portlint -A', 'portfmt -D Makefile' and 'portclippy Makefile'?
The first line of your patch ("# Created by...") is unneeded.
Comment 8 Krzysztof 2024-04-30 08:23:55 UTC 
Created attachment 250299 [details]
update patch

Hello,

I've modified Mkaefile according to current requirements. It was tested with portlint, portfmt. I hope it will be accepted now :-)
Comment 9 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-01 06:14:41 UTC 
(In reply to Krzysztof from comment #8)
First: you are not maintainer of this port so can't set maintainer-approval to +. We should wait for the maintainer (joneum@) approval.

Second: the dependency lines can take from FreshPorts.

Third: I think in this case the flavors would be a better choice (instead of options), see https://docs.freebsd.org/en/books/porters-handbook/book/#flavors
If you use flavors the package builders build nagios-check_clamav-nagios and nagios-check_clamav-monitoring too so can install them from package repository.
Comment 10 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-01 06:16:57 UTC 
(In reply to Zsolt Udvari from comment #9)
First: sorry, didn't notice maintainer timeout. You've right to set maintainer-approval.
Comment 11 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-01 06:18:40 UTC 
You should check "portclippy Makefile" too (part of ports-mgmt/portfmt package).
Comment 12 Krzysztof 2024-05-02 07:40:22 UTC 
(In reply to Zsolt Udvari from comment #9)
Making this modification I was looking at net-mgmt/nrpe. Also net-mgmt/icinga2 is based on options no flavors. So this patch will be "the same".

Thanks a lot for your suggestions. I was looking for portclippy and did not noticed that's a part of portfmt :-)))

I've made new version of patch. It is attached.
Comment 13 Krzysztof 2024-05-02 07:40:49 UTC 
Created attachment 250328 [details]
patch to update the port
Comment 14 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-02 18:26:17 UTC 
(In reply to Krzysztof from comment #12)
And what do you think about flavors as I wrote above?
Comment 15 Krzysztof 2024-05-03 18:48:38 UTC 
(In reply to Zsolt Udvari from comment #14)

For me it is OK. I need some time - probably I'm doing this for the first time :-)))
Comment 16 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-04 12:11:12 UTC 
(In reply to Krzysztof from comment #15)
Okay. If you need help please ask and I try help.
Comment 17 Krzysztof 2024-05-05 07:08:15 UTC 
Created attachment 250413 [details]
patch to update the port

I've made a patch with FLAVOURS. I'm not sure if flavors names are correct. Maybe it should be changed during commit? Maybe it should be as options were (nagplugins/monplugins)?

Any suggestions are good one :-)))
Comment 18 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-09 07:19:03 UTC 
(In reply to Krzysztof from comment #17)
The poudriere show a warning:
Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.

I'm not good in perl, I don't know it is important or not.

And should add an entry to /usr/ports/MOVED (search to "flavor").
Comment 19 Krzysztof 2024-05-10 20:26:52 UTC 
(In reply to Zsolt Udvari from comment #18)
I've made poudriere testport with devel/p5-Module-CoreList as run_depends, but poudriere still complains - this time that corelist is not needed :-))) So I think we can leave it as is.

As I understand I should make a patch to modify MOVED, am I right? And if yes we should be sure that proposed flavours are correct and accepted. Still I'm not sure that proposed flavour names are correct ones...
Comment 20 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-12 17:32:28 UTC 
(In reply to Krzysztof from comment #19)
> As I understand I should make a patch to modify MOVED, am I right?
Yes.

> Still I'm not sure that proposed flavour names are correct ones...
Why? What names would be better?

Another solution (instead of option/flavour) is a pkg-message which describes the optional dependencies. In this case the user should install manually (and after removal of this plugin the "pkg autoremove" doesn't remove the optional dependency).