Bug 262173 - archivers/rpm4: Fix python bindings
Summary: archivers/rpm4: Fix python bindings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-02-24 17:35 UTC by Dmitry Marakasov
Modified: 2022-02-28 15:14 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (rodrigo)


Attachments
Patch (1.42 KB, patch)
2022-02-24 17:35 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2022-02-24 17:35:21 UTC
Created attachment 232081 [details]
Patch

In 468b96cf50e2b1ee6d555a0e6582e8a1d7f41eef, python bindings in rpm4 were broken.

To clarify:
- Python bindings are still included in the distribution and need to be handled the same way as with 4.16.0
- Some third party scripts were moved to python-rpm-packaging module. These are not needed neither for rpm4 not for its python bindings, no dependency on that port is needed for rpm4.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2022-02-24 17:36:32 UTC
PS. archivers/py-python-rpm-packaging is also missing a dependency on bash, as  brp-python-bytecompile uses #!/usr/local/bin/bash
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-25 00:52:38 UTC
Is this:

Approved by: portmgr (blanket(s): regression, runtime fix) ?
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-02-28 13:20:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=371aef9619e152a131b77b25b1bbb5859d474932

commit 371aef9619e152a131b77b25b1bbb5859d474932
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2022-02-24 17:27:24 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2022-02-28 13:18:52 +0000

    archivers/rpm4: fix python bindings

    Fix regression introduced in 468b96c:
    - Reenable python bindings which are still available in this package
    - Remove dependency on py-python-rpm-packaging as it's not related to
      the bindings and is not required for this port operation

    PR:             262173
    Approved by:    portmgr blanket (regression)

 archivers/rpm4/Makefile  | 7 ++++---
 archivers/rpm4/pkg-plist | 3 +++
 2 files changed, 7 insertions(+), 3 deletions(-)
Comment 4 Rodrigo Osorio freebsd_committer freebsd_triage 2022-02-28 15:14:23 UTC
@amdmi3 : Thanks for the fix, I'm not an rpm user, and unfortunately
          I didn't have any feedback when I put out a call for testers.
          Once again sorry for the breakage.