Bug 262703 - [NEW PORT] security/keepass-diff: CLI-tool to diff Keepass (.kdbx) files
Summary: [NEW PORT] security/keepass-diff: CLI-tool to diff Keepass (.kdbx) files
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL: https://github.com/narigo/keepass-diff/
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-21 14:47 UTC by sec.research.2005
Modified: 2023-10-02 12:04 UTC (History)
2 users (show)

See Also:

Attachments
Patch (14.28 KB, patch)
2022-03-21 14:47 UTC, sec.research.2005 		no flags Details | Diff
Poudriere Build Log (272.49 KB, text/plain)
2022-03-21 14:48 UTC, sec.research.2005 		no flags Details
Patch (14.27 KB, patch)
2022-03-21 21:17 UTC, sec.research.2005 		no flags Details | Diff
Patch (14.26 KB, patch)
2022-03-22 21:26 UTC, sec.research.2005 		no flags Details | Diff
Patch after portlint/portclippy/portfmt (14.15 KB, patch)
2022-04-05 13:27 UTC, sec.research.2005 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description sec.research.2005 2022-03-21 14:47:39 UTC 
Created attachment 232607 [details]
Patch

A CLI-tool to diff Keepass (.kdbx) files. Useful, if syncing with Dropbox or NextCloud and getting multiple files due to conflict
Comment 1 sec.research.2005 2022-03-21 14:48:15 UTC 
Created attachment 232608 [details]
Poudriere Build Log
Comment 2 sec.research.2005 2022-03-21 21:17:03 UTC 
Created attachment 232617 [details]
Patch

Fixed Comment and pkg-descr to adopt suggestions from portlint.
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2022-03-22 19:36:45 UTC 
Thanks for the patch of this new port.

Just to issues: 
- New ports should not have a PORTREVISION
- If release files or tagged (release) files are present, they should be used instead of the github download, see the first sentence in section 5.4.3 in the porters handbook[1].

[1] https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-distfiles
Comment 4 sec.research.2005 2022-03-22 21:26:31 UTC 
Created attachment 232641 [details]
Patch

Removed PORTREVISION from the Makefile.
Comment 5 sec.research.2005 2022-03-22 21:28:30 UTC 
(In reply to Rainer Hurling from comment #3)

Thanks! I removed the PORTREVISION from the patch. The port does build a tagged version but the repo and release files are all hosted from Github. There is no other place to download the source but from Github.
Note: The port builds a tagged version, not a random commit hash.
Comment 6 sec.research.2005 2022-04-05 13:27:37 UTC 
Created attachment 232965 [details]
Patch after portlint/portclippy/portfmt

Cleaned up the Makefile & pkg-descr as per portlint/portclippy/pportfmt
Comment 7 Li-Wen Hsu freebsd_committer freebsd_triage 2022-08-01 06:38:49 UTC 
(In reply to sec.research.2005 from comment #0)
Thanks for the patch. If possible, please set your name in https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account so we can use it in `git commit --author`
Comment 8 Li-Wen Hsu freebsd_committer freebsd_triage 2023-01-04 06:21:00 UTC 
(In reply to sec.research.2005 from comment #0)
ping?