Bug 263455 - mail/squirrelmail-shared_calendars-plugin-php81
Summary: mail/squirrelmail-shared_calendars-plugin-php81
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-21 15:51 UTC by James B. Byrne
Modified: 2024-01-31 18:23 UTC (History)
2 users (show)

See Also:


Attachments
patch to squirrelmail/plugins/shared_calendars/classes/calendar.php (1.36 KB, patch)
2024-01-31 18:16 UTC, James B. Byrne
no flags Details | Diff
patch to squirrelmail/plugins/shared_calendars/classes/event.php (521 bytes, patch)
2024-01-31 18:18 UTC, James B. Byrne
no flags Details | Diff
patch to squirrelmail/plugins/shared_calendars/classes/property.php (961 bytes, patch)
2024-01-31 18:19 UTC, James B. Byrne
no flags Details | Diff
patch to squirrelmail/functions/imap_messages.php (10.11 KB, patch)
2024-01-31 18:20 UTC, James B. Byrne
no flags Details | Diff
patch to squirrelmail/functions/mailbox_display.php.php (716 bytes, patch)
2024-01-31 18:21 UTC, James B. Byrne
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James B. Byrne 2022-04-21 15:51:56 UTC
freebsd-version ; uname -a
13.0-RELEASE-p11
FreeBSD webmail-1.hamilton.harte-lyne.ca 13.0-RELEASE-p7 FreeBSD 13.0-RELEASE-p7 #0: Mon Jan 31 18:24:03 UTC 2022     root@amd64-builder.daemonology.net:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64

pkg info squirrelmail-shared_calendars-plugin-php81
squirrelmail-shared_calendars-plugin-php81-2.0.1_3
Name           : squirrelmail-shared_calendars-plugin-php81
Version        : 2.0.1_3
Installed on   : Thu Apr 21 09:44:17 2022 EDT
Origin         : mail/squirrelmail-shared_calendars-plugin
Architecture   : FreeBSD:13:*
Prefix         : /usr/local
Categories     : mail www

Problem:  shared_calendars plugin does not appear in squirrelmail user page.  Calendar Administration does not appear on Options page.

Reproducible: Always

squirrelmail-shared_calendars-plugin-php81 was installed using pkg.  This installed the requisite dependencies as well:

pkg info -x squirrelmail
squirrelmail-calendar_file_backend-plugin-php81-1.0_3
squirrelmail-compatibility-plugin-php81-2.0.16_1
squirrelmail-php81-20211024
squirrelmail-shared_calendars-plugin-php81-2.0.1_3

/usr/local/www/squirrelmail/configure was used to configure squirrelmail. The active plugins are:

Plugins
  Installed Plugins
    1. administrator
    2. bug_report
    3. calendar_file_backend
    4. compatibility
    5. delete_move_next
    6. filters
    7. info
    8. listcommands
    9. message_details
    10. newmail
    11. sent_subfolders
    12. shared_calendars
    13. squirrelspell
    14. translate

The shared_calendars plugin administrators were configured. 

Apache-2.4.53 was configured to access squirrelmail.  mod_php81-8.1.5_2 is installed and enabled in httpd.conf.  

When the squirrelmail page is visited the login page opens, accepts credentials, and proceeds to display the user's mail folders and message list.  The calendar plugin is not added to the page header.  The administration kink is not present on the Options page.
Comment 1 James B. Byrne 2022-04-21 15:57:49 UTC
The error log contains this entry:

PHP Warning:  Undefined variable $thread_name in /usr/local/www/squirrelmail/functions/mailbox_display.php on line 845,
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-12-22 01:40:21 UTC
As Default php has been bumped to php82 is it still the case?
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-12-22 01:40:26 UTC
As Default php has been bumped to php82 is it still the case?
Comment 4 James B. Byrne 2024-01-25 17:53:25 UTC
I have recently installed squirrelmail-php83 and I will test this.
Comment 5 James B. Byrne 2024-01-25 18:42:47 UTC
Problem still exists for shared calendars and perhaps other plugins.
Comment 6 Herbert J. Skuhra 2024-01-25 19:26:24 UTC
This plugin was last updated in 2005!  

https://squirrelmail.org/plugin_view.php?id=105

Requires: PHP 4.1.0, SquirrelMail 1.4.0, Compatibility Plugin, Calendar backend plugin

Why is this still in ports? :)
Comment 7 James B. Byrne 2024-01-25 20:29:50 UTC
At a guess I would say because it has not, to my knowledge, been deprecated upstream.  Most of the squirrelmail plugins do not change very much if at all.
Comment 8 James B. Byrne 2024-01-31 18:16:49 UTC
Created attachment 248094 [details]
patch to squirrelmail/plugins/shared_calendars/classes/calendar.php

refactors code to comply with PHP8
Comment 9 James B. Byrne 2024-01-31 18:18:15 UTC
Created attachment 248095 [details]
patch to squirrelmail/plugins/shared_calendars/classes/event.php

refactors code to comply with PHP8
Comment 10 James B. Byrne 2024-01-31 18:19:23 UTC
Created attachment 248096 [details]
patch to squirrelmail/plugins/shared_calendars/classes/property.php

Refactors code to comply with PHP8
Comment 11 James B. Byrne 2024-01-31 18:20:33 UTC
Created attachment 248097 [details]
patch to squirrelmail/functions/imap_messages.php

Refactors code to comply with PHP8
Comment 12 James B. Byrne 2024-01-31 18:21:47 UTC
Created attachment 248098 [details]
patch to squirrelmail/functions/mailbox_display.php.php

Refactors code to comply with PHP8
Comment 13 James B. Byrne 2024-01-31 18:23:17 UTC
squirrelmail/plugins/shared_calendars/classes/calendar.php.patch
squirrelmail/plugins/shared_calendars/classes/event.php.patch
squirrelmail/plugins/shared_calendars/classes/property.php.patch
squirrelmail/functions/imap_messages.php.patch
squirrelmail/functions/mailbox_display.php.patch 

have been submitted upstream as well.