Bug 263641 - databases/freetds: fix upgrade path
Summary: databases/freetds: fix upgrade path
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2022-04-29 01:19 UTC by Eugene Grosbein
Modified: 2022-05-31 06:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bofh)


Attachments
fix breakage (451 bytes, patch)
2022-04-29 01:20 UTC, Eugene Grosbein
eugen: maintainer-approval? (bofh)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Grosbein freebsd_committer freebsd_triage 2022-04-29 01:19:20 UTC
freetds-1.3.9 and later have the following entry in its ChangeLog:

Author: Frediano Ziglio <freddy77@gmail.com>
Date:   Thu Feb 10 09:40:09 2022 +0000

    Do not install odbcss.h if already in the system

    The provided include is supposed to export some defines that
    should be already be defined by windows headers.
    If they are available they should be used instead.
    This fixed conflict with systems like Windows and possibly MingW.

This change breaks source upgrade of the port on the system that has freetds already installed (this includes portupgrade users):

===>  Building package for freetds-1.3.10,1
actual-package-depends: dependency on /lib/libreadline.so.8 not registered (normal if it belongs to base)
pkg-static: DEBUG: -/

pkg-static: Unable to access file /usr/ports/databases/freetds/work/stage/usr/local/include/odbcss.h:No such file or directory
*** Error code 1

Please consider adding the following one-line patch that fixed the breakage as databases/freetds/patch-configure.ac
Comment 1 Eugene Grosbein freebsd_committer freebsd_triage 2022-04-29 01:20:12 UTC
Created attachment 233570 [details]
fix breakage
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-05-26 08:43:23 UTC
Oops. Looks like I missed this.

I am looking into it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-05-31 06:19:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=399af2d69e8383a7e77ba9dfa0e3bd02bbdc9ab6

commit 399af2d69e8383a7e77ba9dfa0e3bd02bbdc9ab6
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2022-05-31 06:14:13 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2022-05-31 06:14:13 +0000

    databases/freetds: Runtime fix with latest openssl

    - FreeTDS fails to connect with MsSQL after the latest updates of
      OpenSSL specially after the release of 13.1 SNAPSHOTS including
      13.1-RELEASE and more specifically when openssl turned into 1.1.1l
      See the following for more details:
      https://github.com/FreeTDS/freetds/issues/458
    - After the upgrade to version 1.3.9 FreeTDS fails to upgrade when using
      ports tree. [1]

    PR:             261967 263641 [1]
    Reported by:    jsc@ntu.edu.tw eugen [1]

 databases/freetds/Makefile                  |  4 +-
 databases/freetds/files/patch-src_tds_tls.c | 70 ++++++++++++++++++++++++++---
 2 files changed, 68 insertions(+), 6 deletions(-)
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-05-31 06:19:58 UTC
Committed with changes.