Bug 264509 - [new port] editors/gnome-text-editor
Summary: [new port] editors/gnome-text-editor
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-06 22:14 UTC by Tom Pusateri
Modified: 2022-06-14 21:14 UTC (History)
2 users (show)

See Also:

Attachments
tar gzip file of port files (1006 bytes, application/x-compressed-tar)
2022-06-06 22:14 UTC, Tom Pusateri 		no flags Details
Updated version of port files fixing previous comments. (1009 bytes, application/gzip)
2022-06-14 21:14 UTC, Tom Pusateri 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Pusateri 2022-06-06 22:14:28 UTC 
Created attachment 234503 [details]
tar gzip file of port files

Here is a new port for the gnome-text-editor
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-06-07 16:49:45 UTC 
Hi Tom,

Thanks for the patch. gnome@ in copy since this might be in their realm. Some things:

Q/A: WARN: Makefile: [1]: whitespace before end of line
Q/A: Remove the first line of the Makefile (commented empty line)
Q/A: Some variables are out of order. See https://docs.freebsd.org/en/books/porters-handbook/order/
Q/A: replace PORTVERSION with DISTVERSION in MASTER_SITES, for clarity

Thanks!
Comment 2 Tom Pusateri 2022-06-14 20:55:43 UTC 
Thanks for the reply. I will fix the Makefile. What tool do you use to verify it? It's complaining about out of order variables but they appear to be in the correct order.
Comment 3 Tom Pusateri 2022-06-14 21:14:29 UTC 
Created attachment 234688 [details]
Updated version of port files fixing previous comments.

I figured out what was wrong with the portclippy tool.