Bug 264530 - [NEW PORT] devel/gpds: General purpose data serializer library written in modern C++
Summary: [NEW PORT] devel/gpds: General purpose data serializer library written in mod...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dave Cottlehuber
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2022-06-07 23:10 UTC by Joel Bodenmann
Modified: 2022-06-08 13:18 UTC (History)
2 users (show)

See Also:
jbo: maintainer-feedback+

Attachments
commit (2.81 KB, patch)
2022-06-07 23:10 UTC, Joel Bodenmann 		no flags Details | Diff
commit (2.80 KB, patch)
2022-06-07 23:56 UTC, Joel Bodenmann 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Bodenmann freebsd_committer freebsd_triage 2022-06-07 23:10:56 UTC 
Created attachment 234534 [details]
commit

This is a new port for the GPDS C++ library.

Tested with poudriere.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-06-07 23:20:37 UTC 
Thank you for the new port Joel

Could you run the port through portlint / portfmt, there's at least one minor issue (leading indefinite article "A " in comment") which they should pick up.

While this is a development library, might suggest a primary category of 'textproc', leaving 'devel' as the secondary (virtual)
Comment 2 Joel Bodenmann freebsd_committer freebsd_triage 2022-06-07 23:56:55 UTC 
Created attachment 234535 [details]
commit

Thank you for your quick reply!

For unknown reasons I completely jumped the section regarding portlint while following the handbook. I'm sorry - Still learning :)

I've updated the commit/diff/patch to reflect the changes necessary to pass portlint.
Poudriere test still runs successfully.

Regarding the category: This doesn't do text processing by any reasonable definition of "text processing". This is just providing data structures to consuming C++ applications to read & write an XML DOM. No processing takes place. The user of this library would take care of the actual processing.
In my opinion, this fits the devel category just as well as devel/spdlog, devel/fmt and probably most notably: devel/boost.
Furthermore, there are already other serializer libraries in the devel category such as devel/pear-XML_Serializer.
Comment 3 Dave Cottlehuber freebsd_committer freebsd_triage 2022-06-08 13:00:58 UTC 
- portlint AC ok
- poudriere amd64 ok
- portfmt minor changes
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-06-08 13:18:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0d7fa327fe1f4a6282efb372a28c80e188b5f5f9

commit 0d7fa327fe1f4a6282efb372a28c80e188b5f5f9
Author:     Dave Cottlehuber <dch@FreeBSD.org>
AuthorDate: 2022-06-08 13:17:27 +0000
Commit:     Dave Cottlehuber <dch@FreeBSD.org>
CommitDate: 2022-06-08 13:17:27 +0000

    devel/gdps: new port

    General Purpose Data Serializer implemented as a very small C++ library,
    providing (de)serialization of C++ classes, via backends, such as XML.

    PR:             264530
    Sponsored by:   SkunkWerks, GmbH

 devel/Makefile             |  1 +
 devel/gpds/Makefile (new)  | 24 ++++++++++++++++++++++++
 devel/gpds/distinfo (new)  |  3 +++
 devel/gpds/pkg-descr (new) | 10 ++++++++++
 devel/gpds/pkg-plist (new) | 16 ++++++++++++++++
 5 files changed, 54 insertions(+)
Comment 5 Dave Cottlehuber freebsd_committer freebsd_triage 2022-06-08 13:18:37 UTC 
LGTM
- builds on aarch64 as well
- added a WWW: to pkg-descr while here