Bug 274634 - [PATCH] graphics/ImageMagick7: nox11 flavor pulls X11 dependencies
Summary: [PATCH] graphics/ImageMagick7: nox11 flavor pulls X11 dependencies
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-21 18:15 UTC by Andrew
Modified: 2023-11-09 19:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (desktop)


Attachments
Exclude X11-related options in nox11 flavor (284 bytes, patch)
2023-10-21 18:15 UTC, Andrew
andrew.hotlab: maintainer-approval? (desktop)
Details | Diff
configure output (29.47 KB, text/plain)
2023-11-08 10:43 UTC, Andrew
no flags Details
ImageMagick7 Makefile (9.62 KB, text/plain)
2023-11-09 19:41 UTC, Andrew
no flags Details
ImageMagick7 showconfig (1.64 KB, text/plain)
2023-11-09 19:43 UTC, Andrew
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew 2023-10-21 18:15:18 UTC
Created attachment 245786 [details]
Exclude X11-related options in nox11 flavor

The latest version of this port builds a lot of X11 dependencies even with its nox11 flavor. The problem was fixed in #239156, and this patch applies the same fix.
Comment 1 Henrik Hudson 2023-11-06 21:47:39 UTC
I could be reading it wrong, but the current port doesn't even include PANGO, RAQM or SVG unless the x11 flavor is defined. They're not in the default list of defined options nor are they enabled.

That being said, my ImageMagick7@nox11 poudriere build started pulling in X11 dependencies, so there is something going on.
Comment 2 Henrik Hudson 2023-11-06 22:26:36 UTC
For me at least disabling the HEIF support stopped pulling in X11. Looking at the libheif options the defaults definitely cascade to a lot of ports that have X requirements, but I didn't look super close. 

I would think removing HEIF from the main OPTIONS_DEFINE and OPTIONS_DEFAULTS and adding it to the x11 section and the 2 additional OPTIONS_DEFINE and OPTIONS_DEFAULTS would be good.
Comment 3 Andrew 2023-11-08 10:43:07 UTC
Created attachment 246193 [details]
configure output

(In reply to Henrik Hudson from comment #2)
Thanks Henrik, I just tried again: I did a "rmconfig" and disabled the HEIF option, but that didn't prevent the X11 dependencies. I'm compiling on FreeBSD releng/12.4, following Ports branch 2023Q4 (commit d9fea2b9cb23).

I also attached the output of the "configure" step. Here you can read that, for example, PANGO is still listed as dependency (I do not know why).
Comment 4 Henrik Hudson 2023-11-08 16:59:46 UTC
What config options do you have set? What's your Makefile?
Comment 5 Andrew 2023-11-09 19:41:58 UTC
Created attachment 246219 [details]
ImageMagick7 Makefile

(In reply to Henrik Hudson from comment #4)
Here is the Makefile (not modified by the patch)
Comment 6 Andrew 2023-11-09 19:43:30 UTC
Created attachment 246220 [details]
ImageMagick7 showconfig

(In reply to Henrik Hudson from comment #4)
And here are the port's options I selected. Thank for your help.