Bug 275402 - graphics/opencolorio: Udpate to 2.3.2
Summary: graphics/opencolorio: Udpate to 2.3.2
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Loïc Bartoletti
URL:
Keywords:
Depends on:
Blocks: 275303 275819
  Show dependency treegraph
 
Reported: 2023-11-28 08:15 UTC by Loïc Bartoletti
Modified: 2024-05-01 21:07 UTC (History)
5 users (show)

See Also:
FreeBSD: maintainer-feedback+


Attachments
graphics/opencolorio: Update to 2.3.0 (1.83 KB, patch)
2023-11-28 08:15 UTC, Loïc Bartoletti
no flags Details | Diff
graphics/opencolorio: update to 2.3.1 release (5.97 KB, patch)
2023-12-13 10:46 UTC, Dima Panov
no flags Details | Diff
Update to 2.3.2 (20.27 KB, patch)
2024-03-30 01:04 UTC, Alastair Hogge
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti freebsd_committer freebsd_triage 2023-11-28 08:15:45 UTC
Created attachment 246630 [details]
graphics/opencolorio: Update to 2.3.0

Hi,

Please, this is an update of graphics/opencolorio which is required to bump minizip-ng to the latest version (see #275303).

- bump version
- remove files/patch-share_cmake_modules_FindExtPackages.cmake
- fix pkg-plist
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-11-29 08:05:33 UTC
^Triage: reporter is committer, assign accordingly.
Comment 2 Loïc Bartoletti freebsd_committer freebsd_triage 2023-12-06 17:25:48 UTC
"Shane" is it ok for you?
Comment 3 Shane 2023-12-07 00:14:49 UTC
I marked it as approved last week.
Comment 4 Loïc Bartoletti freebsd_committer freebsd_triage 2023-12-07 05:49:42 UTC
(In reply to Shane from comment #3)
AFAIK, there is no "approved" on bugzilla. The '+' is for maintainer-feedback but not for "approved". But, anyway, thanks!
Comment 5 Shane 2023-12-07 22:27:29 UTC
So far, my experience has been that a + for maintainer feedback for the bug has been taken as approval.

There is the ability to approve attachments, but bug poster has to request approval before anyone else is able to change that - see bug #233924
Comment 6 Dima Panov freebsd_committer freebsd_triage 2023-12-13 10:45:33 UTC
(In reply to Loïc Bartoletti from comment #0)
Loic, you have provided a slightly wrong patch.
docs shound be in docs plist, not common



BTW, I've have a 2.3.1 update 


https://people.freebsd.org/~fluffy/-patches/0001-graphics-opencolorio-update-to-2.3.1-release.patch
Comment 7 Dima Panov freebsd_committer freebsd_triage 2023-12-13 10:46:21 UTC
Created attachment 247025 [details]
graphics/opencolorio: update to 2.3.1 release
Comment 8 Loïc Bartoletti freebsd_committer freebsd_triage 2023-12-14 06:55:19 UTC
Indeed, and fyi, Shane, you have to upgrade blender to 4.x. 
Blender 3 doesn't compile with opencolorio 2.3.

Thanks.
Comment 9 Dima Panov freebsd_committer freebsd_triage 2023-12-14 08:18:14 UTC
(In reply to Loïc Bartoletti from comment #8)
Loic, Shane, jfui: I've working on blender4 and have blender 3.6.7 prepared too if anyone interested
https://people.freebsd.org/~fluffy/-patches/0001-graphics-blender-update-to-3.6.7-release.patch
Comment 11 Shane 2023-12-18 09:27:52 UTC
related updates for blender and dependencies:
devel/robin-map bug #275817
graphics/opensubdiv bug #275821
graphics/openimageio bug #275818
graphics/openshadinglanguage bug #275822
graphics/blender bug #275819
Comment 12 Vladimir Druzenko freebsd_committer freebsd_triage 2024-02-10 22:46:42 UTC
Commit?
Comment 13 Dima Panov freebsd_committer freebsd_triage 2024-02-11 20:29:45 UTC
(In reply to Vladimir Druzenko from comment #12)
Needs minizip-ng first

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275303
Comment 14 Loïc Bartoletti freebsd_committer freebsd_triage 2024-02-13 17:37:01 UTC
(In reply to Dima Panov from comment #13)
Should be committed at same time, since opencolorio requires minizip-ng, but opencolorio will be broken (a few days) with the new version of minizip-ng, right?
Comment 15 Dima Panov freebsd_committer freebsd_triage 2024-02-13 17:48:06 UTC
(In reply to Loïc Bartoletti from comment #14)
yep.

ping me as you're be ready. here or via telegram  (https://t.me/FluffyBSD)
Comment 16 Alastair Hogge 2024-03-30 01:04:38 UTC
Created attachment 249571 [details]
Update to 2.3.2

Update to 2.3.2:
- Drop ${OPTIONS_DEFAULT} as the Ports framework already marks DOCS as
  default
- Replace pkg-plist-docs with ${DOCS_PORTDOCS}, add static patch to
  fix installation directory, add post-patch target, and remove
  post-install-DOCS-on target

https://github.com/AcademySoftwareFoundation/OpenColorIO/compare/v2.2.1...v2.3.2

[TESTPORT] main-amd64-current: PASS
[TESTPORT] 13_2-amd64-release: PASS
[TESTPORT] 13_3-amd64-release: PASS
[TESTPORT] 13_3-i386-release: PASS
[TESTPORT] 14_0-amd64-release: PASS
[TESTPORT] main-i386-current: FAIL
[TESTPORT] 13_2-i386-release: FAIL
[TESTPORT] 14_0-i386-release: FAIL
Comment 17 Alastair Hogge 2024-03-30 01:08:25 UTC
Previous tests in comment #6 were against archivers/minizip-ng-4.0.5 (bug #275303)
Comment 18 Alastair Hogge 2024-03-30 06:05:58 UTC
Tested consumers of graphics/opencolorio-2.3.2 with archivers/minizip-ng-4.0.5:

[TESTPORT] poudriere-testport graphics/krita:
[TESTPORT] main-amd64-current: PASS
[TESTPORT] 13_2-amd64-release: PASS
[TESTPORT] 13_3-amd64-release: PASS
[TESTPORT] 13_3-i386-release: PASS
[TESTPORT] 14_0-amd64-release: PASS
[TESTPORT] main-i386-current: FAIL
[TESTPORT] 13_2-i386-release: FAIL
[TESTPORT] 14_0-i386-release: FAIL

[TESTPORT] poudriere-testport graphics/art:
[TESTPORT] main-amd64-current: PASS
[TESTPORT] 13_2-amd64-release: PASS
[TESTPORT] 13_3-amd64-release: PASS
[TESTPORT] 13_3-i386-release: PASS
[TESTPORT] 14_0-amd64-release: PASS
[TESTPORT] main-i386-current: FAIL
[TESTPORT] 13_2-i386-release: FAIL
[TESTPORT] 14_0-i386-release: FAIL
Comment 19 Shane 2024-03-31 02:23:53 UTC
(In reply to Alastair Hogge from comment #18)

I'm ok with the other changes with 2.3.2 update.

The current port fails on i386 13.2/14.0/main because it can't find zstd, from archivers/zstd.
Its odd that 13.3-i386 builds but 14.0-i386 and main-i386 fail. Fixes should happen in main and filter down to 13.3, maybe that means the break has not been merged down to 13 yet.
Comment 20 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-01 21:07:56 UTC
Update of blender and all dependencies in one patch: https://reviews.freebsd.org/D45051