Created attachment 247203 [details] patch
> -#if !defined(HAS_STRPTIME) > +#if 0 && !defined(HAS_STRPTIME) Hmm, that does not look very neat, let's wait until we have a better fix and/or feedback from upstream developers.
(In reply to Alexey Dokuchaev from comment #1) Hi Alexey, We can just remove this code section for now since it is erroneous on FreeBSD. It was added on some linux flavor to solve the name collision, but that was just a mistake since that name collision can be resolved better using a qualifier like this patch suggests. This blocks math/or-tools from being updated. Thanks, Yuri
Okay so it was actually fixed upstream*, they just don't like to talk to people on GitHub. Can you please replace the patch in files/ with these two lines: PATCH_SITES= https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/ PATCHFILES= <commit-hash-or-part-of-it-as-long-as-you-like>.patch:-p1 As usual, check that update does not break consumer ports and you're good to go. *) https://github.com/abseil/abseil-cpp/commit/ded2ec077d911de647d47ab48ef3a8e24a1fb64a
Abseil LTS 20240116.0 had been released and builds without patches.
*** Bug 276718 has been marked as a duplicate of this bug. ***
Created attachment 248083 [details] Patch for abseil Use upstream release archive Minor adjustments to Makefile to closer follow Porters Handbook Poudriere testport OK 13.2-RELEASE (amd64) Poudriere testport OK 14.0-RELEASE (amd64) Tested with following consumers on 13.2-RELEASE (amd64) using Poudriere: audio/webrtc-audio-processing audio/mumble audio/mumble-server audio/murmur audio/py-torchaudio audio/strawberry benchmarks/apib cad/openroad (skipped due to math/or-tools) devel/bear devel/google-cloud-cpp devel/grpc devel/grpc142 (fails, only one consumer left (PR 276516)) devel/libphonenumber devel/protobuf (current version in tree needs c++20 to compile) devel/re2 devel/youcompleteme editors/libreoffice graphics/s2 math/obake math/or-tools (fails, needs patching) math/py-or-tools (fails, needs patching) math/py-pyaudi misc/ncnn misc/py-pytorch (fails, needs patching) misc/pytorch multimedia/libgav1 net/libilbc net-im/telegram-desktop net-mgmt/fastnetmon security/crowdsec sysutils/fusefs-securefs www/envoy (fails, not related) Unit tests fails to compile using either CMAKE_CXX_STANDARD=17 or CMAKE_CXX_STANDARD=20
or-tools-9.8 fail to build with abseil-20230125.3: https://github.com/google/or-tools/issues/4070
pytorch-2.2.0 builds fine with abseil-20230125.3.
(In reply to Daniel Engberg from comment #6) > Use upstream release archive Okay, let's use it. > Minor adjustments to Makefile to closer follow Porters Handbook Please no, the Makefile is fine as it is now. :-) > devel/grpc142 (fails, only one consumer left, bug #276516) It's currently marked BROKEN (fails to build) so I guess we can ignore it. > math/or-tools (fails, needs patching) > math/py-or-tools (fails, needs patching) > misc/py-pytorch (fails, needs patching) These are Yuri's ports, he'll probably fix those (albeit he talks about existing version 20230125.3 in the comments above for some reason). Yuri, can you see what's up with your ports and prepare against proposed version 20240116.0? If feasible, you can patch them so they can be built against both current and new versions; if not, they'd had to be updated together with Abseil. > devel/protobuf (current version in tree needs c++20 to compile) Not sure what to do about this one.
or-tools-9.8 fails to build with abseil-20240116.0: https://github.com/google/or-tools/issues/4074 (the previous or-tools issue was probably mis-filed and was for a wrong abseil version.)
Created attachment 248753 [details] math/or-tools update to version 9.8 I've done another build run yesterday against Abseil LTS 20240116.1 and found that only `math/{py-,}or-tools' exhibit related errors. I've quickly hacked update to version 9.8 which builds fine (similar patch for py- port is left as an exercise to the reader). (In reply to Yuri Victorovich from comment #10) > or-tools-9.8 fails to build with abseil-20240116.0 Please take a look at the attached PoC patch. If you won't mind, I can commit `devel/abseil' update first which you'd follow with `math/{py-,}or-tools' update.
*** Bug 279366 has been marked as a duplicate of this bug. ***