Bug 277348 - x11/wmctrl: upstream no longer exists
Summary: x11/wmctrl: upstream no longer exists
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Felix Palmen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-27 10:35 UTC by Alexey Vyskubov
Modified: 2024-05-18 11:54 UTC (History)
1 user (show)

See Also:


Attachments
port upgrade (4.60 KB, application/mbox)
2024-02-27 10:35 UTC, Alexey Vyskubov
no flags Details
port upgrade (4.60 KB, patch)
2024-02-27 10:47 UTC, Alexey Vyskubov
no flags Details | Diff
New patch for ports tree. (6.34 KB, patch)
2024-05-18 11:54 UTC, Alexey Vyskubov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Vyskubov 2024-02-27 10:35:45 UTC
Created attachment 248787 [details]
port upgrade

The port for the current version (1.07) points to the upstream which no longer exists. Also the port has no maintainer. The attached patch points to my own github fork and adds me as a port maintainer.
Comment 1 Alexey Vyskubov 2024-02-27 10:47:25 UTC
Created attachment 248788 [details]
port upgrade

new version of the patch, uses DISTVERSION not PORTVERSION
Comment 2 Felix Palmen freebsd_committer freebsd_triage 2024-03-14 08:50:21 UTC
Hi and thanks for your contribution!

First I have a question: Did you attempt to contact the original upstream maintainer? If not, could you please do so? I think it's important because otherwise, it's unclear whether "wmctrl-1.09" would refer to your fork or maybe to some other fork.

If the original upstream maintainer isn't available, or unwilling to pass upstream maintainership, I'd very much prefer a different name (maybe just adding some prefix or suffix) to avoid any confusion. Or maybe as another option, host the original distfile somewhere along with a patch to make it work (and then of course keep the version at 1.07).

This aside, you probably want to clean your github fork from all GNU autotools generated files. To avoid having to use USES=autoreconf, the best option is to generate an actual disfile (IIRC GNU autotools supports "make dist" for that) and upload it to a release on github ... thus also avoiding the need for USE_GITHUB=yes.

Finally, at a first glance, please don't add to variables when not needed, like here:

USE_XORG=	x11 xmu xext xt
USE_XORG+=	ice
USE_XORG+=	sm

The correct way would be

USE_XORG=	ice sm x11 xext xmu xt

(alphabetically sorted)
Comment 3 Alexey Vyskubov 2024-03-14 11:21:11 UTC
I did not try to contact the original upstream author. I have sent an email now, let's see what is the result.
Comment 4 Alexey Vyskubov 2024-03-14 11:23:30 UTC
Ok, I got a rejection from postmaster@.

I will try to find the author, though.
Comment 5 Felix Palmen freebsd_committer freebsd_triage 2024-03-14 11:25:51 UTC
(In reply to Alexey Vyskubov from comment #4)
Thanks for the effort.

In the case the author disappeared, I think starting your own fork is indeed the best thing to do for keeping it alive. Just as I said, please do something with the name in that case to avoid any possible confusion. The port can then be renamed as well with an appropriate entry in MOVED.
Comment 6 Alexey Vyskubov 2024-05-18 11:52:17 UTC
Hello again,

I have tried to reach the upstream author using different channels, but failed. I attach the new patch which hopefully takes your comments into account. Please have a look.
Comment 7 Alexey Vyskubov 2024-05-18 11:54:20 UTC
Created attachment 250790 [details]
New patch for ports tree.