Bug 277588 - net/openradius: remove dead MASTERSITES, cleanup Makefile and patch files, update to 0.9.13
Summary: net/openradius: remove dead MASTERSITES, cleanup Makefile and patch files, up...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Zsolt Udvari
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2024-03-08 23:54 UTC by Chris Hutchinson
Modified: 2024-04-30 19:03 UTC (History)
1 user (show)

See Also:

Attachments
patch for net/openradius (5.00 KB, patch)
2024-03-08 23:54 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
patch against net/openradius (5.61 KB, patch)
2024-03-09 04:11 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
patch for net/openradius (version 3) (5.79 KB, patch)
2024-04-30 03:42 UTC, Chris Hutchinson 		portmaster: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2024-03-08 23:54:19 UTC 
Created attachment 249042 [details]
patch for net/openradius

This pr(1) removes a dead MASTERSITES. While here
cleanup Makefile, and patch files.

That's it.

Thanks!

--Chris
Comment 1 Chris Hutchinson 2024-03-09 04:11:47 UTC 
Created attachment 249044 [details]
patch against net/openradius

Committed local source changes and posted source to public VCS.

Changes:
Change MASTERSITES, bump version (0.9.13), cleanup patches.
update distinfo.

Tested against releng/13,14 and CURRENT.

That's it.

Thanks
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2024-04-14 18:30:28 UTC 
Could you check please "portfmt -D Makefile"?
Could you replace ".if ${PORT_OPTIONS:MLDAP}" to "Options Helpers" (https://docs.freebsd.org/en/books/porters-handbook/book/#options-helpers)?
Comment 3 Chris Hutchinson 2024-04-30 03:42:09 UTC 
Created attachment 250295 [details]
patch for net/openradius (version 3)

Sorry. I seemed to have missed this.

> Could you check please "portfmt -D Makefile"?
DONE

> Could you replace ".if ${PORT_OPTIONS:MLDAP}" to "Options Helpers"
All attempts reject any incantation of the SCRIPTS_ENV
Comment 4 Zsolt Udvari freebsd_committer freebsd_triage 2024-04-30 18:30:28 UTC 
(In reply to Chris Hutchinson from comment #3)
"All attempts reject any incantation of the SCRIPTS_ENV"
Did you try OPT_VARS?
https://docs.freebsd.org/en/books/porters-handbook/book/#options-vars

Can be the post-install target simpler? As I see you copy (almost) every file. Maybe you may want check https://docs.freebsd.org/en/books/porters-handbook/book/#install-copytree

I'm checking your "scripts/configure". As I see it overwrites openradius's Makefile, only with a small changes.
I don't know openradius but the modules/memory/memory isn't included in your TGT_LIB. Is it intentional? And the S_CF_CRYPT is missed too.
Your configure script declare AR variable but in the original Makefile there is ARCHIVE variable (and it's used common/ and language/Rules.mk).
And if I understand correctly the CF_ALL is CFLAGS. Why don't you use the system's CFLAGS? (https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags)
As I see you want modify the Makefile because of only LOGFILE and LDAP.
What do you think about create a patch? IMHO it would be simpler and easier to maintain - and in this case you don't need SCRIPTS_ENV :)
Comment 5 Chris Hutchinson 2024-04-30 19:03:05 UTC 
(In reply to Zsolt Udvari from comment #4)
All really good points.
I'll submit something later today.

Thanks.