Bug 277743 - devel/jetbrains-pty4j: Added aarch64 compatibility
Summary: devel/jetbrains-pty4j: Added aarch64 compatibility
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-16 21:57 UTC by Dmitry Wagin
Modified: 2024-05-06 09:13 UTC (History)
2 users (show)

See Also:


Attachments
jetbrains-pty4j.diff (999 bytes, patch)
2024-03-16 21:57 UTC, Dmitry Wagin
dmitry.wagin: maintainer-approval+
Details | Diff
Use bsd.lib.mk (2.22 KB, patch)
2024-04-04 18:24 UTC, Mikhail Teterin
no flags Details | Diff
files/BSDmakefile (115 bytes, text/plain)
2024-04-04 18:30 UTC, Mikhail Teterin
no flags Details
jetbrains-pty4j.diff (1.87 KB, patch)
2024-04-05 04:15 UTC, Dmitry Wagin
dmitry.wagin: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Wagin 2024-03-16 21:57:15 UTC
Created attachment 249223 [details]
jetbrains-pty4j.diff

Added aarch64 compatibility and cleanup port
Comment 1 Mikhail Teterin freebsd_committer freebsd_triage 2024-04-04 18:24:31 UTC
Created attachment 249711 [details]
Use bsd.lib.mk

Instead of trying to use the upstream's makefiles, why not simply compile the little shared library using the standard bsd.lib.mk? That will make the port build for all architectures too...

The proposed patch does that while also providing these other minor improvements:
 - upgrade the port to upstream's 0.12.26
 - stop extracting the upstream's pre-built binaries (which they never should've
   added to their git repo in the first place).
Comment 2 Mikhail Teterin freebsd_committer freebsd_triage 2024-04-04 18:30:14 UTC
Created attachment 249712 [details]
files/BSDmakefile

> The proposed patch does that 

Argh, the `git diff` didn't include my newly-added files/BSDmakefile with the patch, so here it is by itself. Sorry for the additional noise.
Comment 3 Dmitry Wagin 2024-04-05 04:15:02 UTC
Created attachment 249729 [details]
jetbrains-pty4j.diff

 - upgrade the port to upstream's 0.12.26
 - stop extracting the upstream's pre-built binaries.
Comment 4 Dmitry Wagin 2024-04-05 04:18:03 UTC
(In reply to Mikhail Teterin from comment #1)

I don't see the point in maintaining an additional Makefile. All architectures are not needed, only specific ones.
Comment 5 Mikhail Teterin freebsd_committer freebsd_triage 2024-04-07 00:17:01 UTC
(In reply to Dmitry Wagin from comment #4)
> I don't see the point in maintaining an additional Makefile

Seems like fewer lines of code, than you have now. And no need for gmake any more...

> All architectures are not needed, only specific ones.

I don't understand this statement... Why shouldn't the port (try to) cover all of FreeBSD's architectures?
Comment 6 Dmitry Wagin 2024-04-07 22:09:51 UTC
(In reply to Mikhail Teterin from comment #5)

>> All architectures are not needed, only specific ones.

> I don't understand this statement... Why shouldn't the port (try to) cover all of FreeBSD's architectures?

Other ports that use this port are limited by these architectures, there is no point in building (just a waste of resources).
Comment 7 Li-Wen Hsu freebsd_committer freebsd_triage 2024-05-06 09:13:51 UTC
Suppressed by bug278803.