Bug 278349 - [NEW PORT] games/star_traders: Simple text-based game of interstellar trading
Summary: [NEW PORT] games/star_traders: Simple text-based game of interstellar trading
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-13 17:22 UTC by Petteri Valkonen
Modified: 2024-05-19 05:25 UTC (History)
1 user (show)

See Also:

Attachments
Patch to add games/star_traders (3.81 KB, patch)
2024-04-13 17:22 UTC, Petteri Valkonen 		petteri.valkonen: maintainer-approval+
Details | Diff
Patch to add games/star_traders and SUBDIR entry (4.41 KB, patch)
2024-05-03 06:06 UTC, Petteri Valkonen 		petteri.valkonen: maintainer-approval+
Details | Diff
Patch to add games/star_traders and SUBDIR entry (reformatted) (5.29 KB, patch)
2024-05-04 13:23 UTC, Petteri Valkonen 		petteri.valkonen: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Valkonen 2024-04-13 17:22:47 UTC 
Created attachment 249958 [details]
Patch to add games/star_traders

Star Traders is a simple text-based game of interstellar trading, where the objective is to create companies, buy and sell shares, borrow and repay money, in order to become the wealthiest player (the winner).

WWW: https://www.zap.org.au/projects/trader/
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-04-29 18:29:09 UTC 
Hi Petteri,
you should add a SUBDIR entry into ports/games/Makefile too.
Comment 2 Petteri Valkonen 2024-05-03 06:06:56 UTC 
Created attachment 250348 [details]
Patch to add games/star_traders and SUBDIR entry

Please find attached a updated patch which adds both the games/star_traders subdirectory and a SUBDIR entry for it.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-04 12:16:04 UTC 
(In reply to Petteri Valkonen from comment #2)
Thanks!
Could you please check 'portlint -A', 'portfmt -D Makefile' and 'portclippy Makefile'? (these programs are parts of ports-mgmt/portlint and ports-mgmt/portfmt)
Comment 4 Petteri Valkonen 2024-05-04 13:23:14 UTC 
Created attachment 250364 [details]
Patch to add games/star_traders and SUBDIR entry (reformatted)

Sure. Attached is a updated patch where the Makefile has been re-arranged according to portclippy's output. Portlint and portfmt didn't find any issues.
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-04 18:33:54 UTC 
I sent to my mentors to approve: https://reviews.freebsd.org/D45091
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-05-19 05:24:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5c99d2c5f6207b05f9cb749ee47c987f14b796ab

commit 5c99d2c5f6207b05f9cb749ee47c987f14b796ab
Author:     Petteri Valkonen <petteri.valkonen@iki.fi>
AuthorDate: 2024-05-19 05:17:22 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-05-19 05:21:07 +0000

    games/star_traders: new port: text-based game

    Star Traders is a simple text-based game of interstellar trading,
    where the objective is to create companies, buy and sell shares,
    borrow and repay money, in order to become the wealthiest player
    (the winner).

    WWW: https://www.zap.org.au/projects/trader/

    PR:             278349
    Approved by:    submitter is maintainer, diizzy (mentor)
    Differential Revision:  https://reviews.freebsd.org/D45091

 games/Makefile                     |  1 +
 games/star_traders/Makefile (new)  | 27 +++++++++++++++++++++++++++
 games/star_traders/distinfo (new)  |  3 +++
 games/star_traders/pkg-descr (new) |  3 +++
 games/star_traders/pkg-plist (new) | 35 +++++++++++++++++++++++++++++++++++
 5 files changed, 69 insertions(+)
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-05-19 05:25:24 UTC 
Committed, thanks!