Bug 278732 - www/gohugo: Update to v125.5
Summary: www/gohugo: Update to v125.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Document Engineering Group (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 11:49 UTC by László Károlyi
Modified: 2024-05-06 17:10 UTC (History)
2 users (show)

See Also:
fernape: maintainer-feedback+


Attachments
Update to v125.5 (1.21 KB, patch)
2024-05-04 11:49 UTC, László Károlyi
no flags Details | Diff
Update to v125.5 w/o PORTREVISION (1.19 KB, patch)
2024-05-04 14:19 UTC, László Károlyi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description László Károlyi 2024-05-04 11:49:03 UTC
Created attachment 250363 [details]
Update to v125.5

Attached you'll find the diff for updating to v125.5. I've tested it locally compiled, works.

Please merge it and all the good stuff, so I can have the latest version (where the sitemap.xml exclusion parameter is included, it's why I need it).

Thanks!
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-04 13:17:18 UTC
You don't need PORTREVISION=1.
Comment 2 László Károlyi 2024-05-04 13:34:45 UTC
(In reply to Vladimir Druzenko from comment #1)
Are you sure?

As per the FreeBSD porters handbook:

> PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way. That includes changes that only affect a package built with non-default options.

I'm open to deleting it, but setting it to 1 seemed to be the right way.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-04 13:38:17 UTC
You increase DISTVERSION.
PORTREVISION is only needed if DISTIVERSION is not increased.
Comment 4 László Károlyi 2024-05-04 13:42:11 UTC
(In reply to Vladimir Druzenko from comment #3)
I did'nt add PORTREVISION, it originally was increased in 32b284679a1954ef1e0c0d52c4741d00e36dc6e0 from 1 to 2. I'm just setting it back to 1 (since there is a new portversion).

Should I _entirely_ remove it? As in, the entire line?
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-04 14:17:54 UTC
(In reply to László Károlyi from comment #4)
Yes, remove it.
Comment 6 László Károlyi 2024-05-04 14:19:50 UTC
Created attachment 250368 [details]
Update to v125.5 w/o PORTREVISION

Your command is my wish :)

Attached the new diff.
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-04 14:54:58 UTC
Oh, maintainer is doceng@… I cannot commit without approval from a member of this group before the two-week maintainer timeout expires.
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-04 16:15:54 UTC
There is ongoing work to commit this.
A review for the previous version also exists:

https://reviews.freebsd.org/D44939

I'll take care of this.
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2024-05-06 17:09:54 UTC
Updated to 0.125.6

Thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-05-06 17:10:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ea725f715f4d2f2198df8cf05d7d9dc18a0101ee

commit ea725f715f4d2f2198df8cf05d7d9dc18a0101ee
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2024-04-22 10:49:40 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2024-05-06 17:10:16 +0000

    www/gohugo: update to 0.125.4

    Summary:
    ChangeLog: https://github.com/gohugoio/hugo/releases/tag/v0.125.4
               https://github.com/gohugoio/hugo/releases/tag/v0.125.5
               https://github.com/gohugoio/hugo/releases/tag/v0.125.6

    Doc and website seems (under visual inspection) to be built properly.
    No new warnings during building AFAICT.

    Test Plan:
    * Apply patch and run `make` at the top level doc tree
    * Build `misc/freebsd-doc-all`

    PR:                     278732
    Reviewed by:            dbaio@
    Differential Revision:  https://reviews.freebsd.org/D44939

 www/gohugo/Makefile |  3 +--
 www/gohugo/distinfo | 10 +++++-----
 2 files changed, 6 insertions(+), 7 deletions(-)