Bug 278740 - net/libilbc: Use EXTRACT_AFTER_ARGS
Summary: net/libilbc: Use EXTRACT_AFTER_ARGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 18:26 UTC by Daniel Engberg
Modified: 2024-05-20 22:00 UTC (History)
0 users

See Also:
nc: maintainer-feedback+

Attachments
Patch for libilbc (387 bytes, patch)
2024-05-04 18:26 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libilbc v2 (444 bytes, patch)
2024-05-05 13:37 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 18:26:10 UTC 
Created attachment 250376 [details]
Patch for libilbc

Skip extracting abseil-cpp instead of deleting it after extracting to reduce I/O

Poudriere bulk OK
Comment 1 Neel Chauhan freebsd_committer freebsd_triage 2024-05-04 21:12:54 UTC 
LGTM. Feel free to commit.

If you prefer that I commit, let me know and I will do it.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 13:37:23 UTC 
Created attachment 250453 [details]
Patch for libilbc v2

Be more specific about what files to remove and preserve original flags
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 13:37:42 UTC 
Thanks, I'll commit it later
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-20 21:54:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b5e40b0c72f67288acaa7c9fee231812573bed0c

commit b5e40b0c72f67288acaa7c9fee231812573bed0c
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-05-20 21:37:15 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-05-20 21:53:51 +0000

    net/libilbc: Use EXTRACT_AFTER_ARGS to reduce I/O load

    Skip extracting abseil-cpp instead of deleting it after
    extracting to reduce I/O

    PR:             278740
    Reviewed by:    nc (maintainer)

 net/libilbc/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-05-20 22:00:59 UTC 
Committed, thanks!