Bug 278741 - audio/mpz: Use EXTRACT_AFTER_ARGS to reduce I/O
Summary: audio/mpz: Use EXTRACT_AFTER_ARGS to reduce I/O
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 18:29 UTC by Daniel Engberg
Modified: 2024-05-07 18:27 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
Patch for mpz (616 bytes, patch)
2024-05-04 18:29 UTC, Daniel Engberg
no flags Details | Diff
Patch for mpz v2 (749 bytes, patch)
2024-05-05 12:27 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 18:29:16 UTC
Created attachment 250377 [details]
Patch for mpz

Instead of extracting and then deleteing just skip extracting directly

Poudriere bulk OK
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 12:27:35 UTC
Created attachment 250436 [details]
Patch for mpz v2

Be more specific about what files to remove and preserve original flags
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-05-07 09:54:58 UTC
Not sure if added complexity warrants the change, but I see the point of not extracting needless bits rather then deleting them.  Could you elaborate on the ${GH_PROJECT_DEFAULT}-${GH_TAGNAME_EXTRACT} abomination vs. just ${GH_PROJECT}-${GH_TAGNAME}?
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-05-07 18:27:19 UTC
Because they're not the referenced variables in framework, https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n1733