Bug 278754 - games/xray_re-tools: Use EXTRACT_AFTER_ARGS
Summary: games/xray_re-tools: Use EXTRACT_AFTER_ARGS
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 18:58 UTC by Daniel Engberg
Modified: 2024-05-08 03:01 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)

Attachments
Patch for xray_re-tools (903 bytes, patch)
2024-05-04 18:58 UTC, Daniel Engberg 		no flags Details | Diff
Patch for xray_re-tools v2 (1.05 KB, patch)
2024-05-05 13:04 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 18:58:47 UTC 
Created attachment 250390 [details]
Patch for xray_re-tools

Instead of extracting unused dependencies just skip them instead to reduce I/O

Poudriere bulk OK
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 13:04:19 UTC 
Created attachment 250446 [details]
Patch for xray_re-tools v2

Be more specific about what files to remove and preserve original flags
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-05-08 03:01:35 UTC 
This one is particularly good example of why I'm skeptical about this little quest of yours, or rather its current form.  Here you want to replace one simple, readable, DRY line with three long, yet similar ones.  I need to think how to shorten this and make less error-prone, shall I decide to accept it.

Do you have plans to generalize the whole thing and make it part of the Mk/b.p.m framework, hiding all this ${GH_PROJECT_DEFAULT}-${GH_TAGNAME_EXTRACT} nastiness and repetitive --exclude's behind the curtain and, for multi-distfile ports, applied only to specific distfile that needs it?