Bug 278759 - devel/pycharm-ce: Use EXTRACT_AFTER_ARGS
Summary: devel/pycharm-ce: Use EXTRACT_AFTER_ARGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 19:11 UTC by Daniel Engberg
Modified: 2024-05-06 20:30 UTC (History)
1 user (show)

See Also:
jonc: maintainer-feedback+

Attachments
Patch for pycharm-ce (1.75 KB, patch)
2024-05-04 19:11 UTC, Daniel Engberg 		no flags Details | Diff
Patch for pycharm-ce v2 (1.91 KB, patch)
2024-05-05 11:32 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 19:11:08 UTC 
Created attachment 250395 [details]
Patch for pycharm-ce

Skip extracting unnecessary files instead of deleting them after extraction to reduice I/O

Poudriere bulk OK
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 11:32:37 UTC 
Created attachment 250427 [details]
Patch for pycharm-ce v2

Be more specific about what files to remove and preserve original flags
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 11:33:18 UTC 
Thanks, given it's a minor fix I'll consider the new patch as approved as well
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-06 20:26:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dc99303b1691df946e9223cc9756e120e1ff38ec

commit dc99303b1691df946e9223cc9756e120e1ff38ec
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-05-06 20:02:58 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-05-06 20:08:41 +0000

    devel/pycharm-ce: Use EXTRACT_AFTER_ARGS

    To decrease I/O load skip extracting files instead of removing after
    extraction

    PR:             278759
    Reviewed by:    Jonathan Chen <jonc@chen.org.nz> (maintainer, previous version)

 devel/pycharm-ce/Makefile | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-05-06 20:30:39 UTC 
Committed, thanks!