Bug 278785 - audio/libmysofa: Don't extract test directory unless requested
Summary: audio/libmysofa: Don't extract test directory unless requested
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-05 14:23 UTC by Daniel Engberg
Modified: 2024-05-06 02:28 UTC (History)
0 users

See Also:
jhale: maintainer-feedback+

Attachments
Patch for libmysofa (1.72 KB, patch)
2024-05-05 14:23 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 14:23:39 UTC 
Created attachment 250459 [details]
Patch for libmysofa

Instead of extracting  ~200mbytes each time just extract test files when requested
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-05-06 02:25:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37afd1559b9785f4cc3335aa76c9a0962e52f892

commit 37afd1559b9785f4cc3335aa76c9a0962e52f892
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-05-06 02:15:32 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-05-06 02:23:32 +0000

    audio/libmysofa: Limit extraction of test data

    The test data is very large (~250 Mib). Only extract it if the TEST
    option is enabled to save on I/O.

    While here, pet portclippy(1).

    PR:             278785

 audio/libmysofa/Makefile                                  | 15 +++++++++++----
 ...patch-tests_compare.sh => extrapatch-tests_compare.sh} |  0
 ...eIgnoreNew.sh => extrapatch-tests_compareIgnoreNew.sh} |  0
 3 files changed, 11 insertions(+), 4 deletions(-)
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2024-05-06 02:28:23 UTC 
Committed with minor changes, thanks!