Bug 278793 - x11-fonts/fira: Simplify port
Summary: x11-fonts/fira: Simplify port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-05 18:42 UTC by Daniel Engberg
Modified: 2024-05-07 19:27 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (trueos)

Attachments
Patch for fira (1.56 KB, patch)
2024-05-05 18:42 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 18:42:29 UTC 
Created attachment 250468 [details]
Patch for fira

Just extract what we really need which makes it cleaner and faster
Comment 1 Trenton Schulz 2024-05-07 17:39:49 UTC 
Comment on attachment 250468 [details]
Patch for fira

I approve of this patch. We don't need a "DOCS" option. I guess since you are going touching this port, you could also remove the mention to www/fira-webfont in pkg-message.in.

I do think that port existed at some point, but it does not exist now.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-07 19:26:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ac8a8a98c1a76070d4be08b292cca599ef1ab3f1

commit ac8a8a98c1a76070d4be08b292cca599ef1ab3f1
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-05-07 18:19:48 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-05-07 19:26:02 +0000

    x11-fonts/fira: Simplify port

    * Just extract what we really need which makes it cleaner and
      reduces I/O.
    * Drop DOCS option
    * Remove reference of www/fira-webfont (pointed out by maintainer)

    PR:             278793
    Reviewed by:    Trenton Schulz <trueos@norwegianrockcat.com> (maintainer)

 x11-fonts/fira/Makefile             | 30 ++++++++++++++----------------
 x11-fonts/fira/files/pkg-message.in |  1 -
 2 files changed, 14 insertions(+), 17 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-05-07 19:27:08 UTC 
Committed, thanks