Created attachment 250524 [details] trivial update of Makefile and distinfo
Hi, Did you run this through poudriere-testport? Getting some QA issue on my end: > Error: RubyGem dependency psych < 5.1.2 is not satisfied.
That error might be thrown because textproc/rubygem-psych is 5.1.2 and this port expects a version between 5.0.1 and 5.1.1 as for the gemspec: https://github.com/oracle/oci-ruby-sdk/blob/master/oci.gemspec#L30 What's your recommendation about it? Thank you
The ideal case would be to patch upstream and updating the port once upstream was patched. However, depending upstream that can take a while™. In such a case, you'd typically maintain a local patch within the port itself. A quick glance over the psych commit history would suggest that updating from 5.1.1 to 5.1.2 is relatively safe.
Created attachment 250620 [details] trivial update of Makefile and distinfo Thanks a lot for the feedback Joel! I am attaching a new patch to this bug, let me know if it also fixes the issue for you
Hello jbo@, did you have a chance to look into the updated patch? Thank you
Apologies - I haven't. I'm currently moving to a different apartment. That is eating up a ton of time. I'll try to get to this tomorrow.
no worries, let me know when you have time to check it and if there's any other change I should make to the patch! Thank you
hi jbo@, I saw the package was already patched upsteeam to support the correct psych gem version, please find the commit here [1] do you agree it's better to bump directly to the latest upstream version so we don't have to create a local patch that will be removed in the next port update? Thank you [1] https://github.com/oracle/oci-ruby-sdk/commit/53b657ac79cff02c4d4c9266e5fdb612d29180c2
Created attachment 250859 [details] trivial update of Makefile and distinfo I updated the patch for latest version, 2.21.1 :)
That is indeed the correct thing to do :)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=60fbd70ebe977098c79d0933c0bc07b40150ced7 commit 60fbd70ebe977098c79d0933c0bc07b40150ced7 Author: Alessandro Sagratini <ale_sagra@hotmail.com> AuthorDate: 2024-05-21 18:21:38 +0000 Commit: Joel Bodenmann <jbo@FreeBSD.org> CommitDate: 2024-05-21 22:59:57 +0000 devel/rubygem-oci: Update to 2.21.1 Changelog: v2.21.1: https://github.com/oracle/oci-ruby-sdk/releases/tag/v2.21.1 v2.21.0: https://github.com/oracle/oci-ruby-sdk/releases/tag/v2.21.0 PR: 278850 Approved by: tcberner (mentor, implicit) devel/rubygem-oci/Makefile | 5 +++-- devel/rubygem-oci/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-)
Committed - Thanks! I have updated the git author e-mail address to match your MAINTAINER= field as well as your bugzilla e-mail address. There was also a typo in the commit message (rubygen).