Created attachment 235516 [details] Unload any previously loaded kernel when changing boot environment. Related to a bug fixed by Kyle Evans <kevans@FreeBSD.org> in commit e414851f3eb7a9dd2af8209eac4ada307cb6ff8e, if a password is set for the loader, when the boot environment is changed in the lua menu, the kernel originally loaded before the menu was brought up is booted in the new boot environment. Since the kernel directory isn't mounted, this prevents modules from being loaded during boot. In addition, if the reason for using the boot environment is to provide a known good kernel and environment, well... I've attached a patch.
Created attachment 235518 [details] Unload any previously loaded kernel when changing boot environment. Too much C, not enough Lua.
Keyword: patch or patch-ready – in lieu of summary line prefix: [patch] * bulk change for the keyword * summary lines may be edited manually (not in bulk). Keyword descriptions and search interface: <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
Created attachment 241367 [details] Unload any previously loaded kernel when changing boot environment. Update to 13.2-RELEASE
Can you please provide me with a string suitable for --author attribution for one of these patches? This is typically "name <email>"
Cyrus Rahman <crahman@gmail.com> would be fine. Thanks
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=d7584aa09fcf8d96544e5bfb3ea78f50d7720c0c commit d7584aa09fcf8d96544e5bfb3ea78f50d7720c0c Author: Cyrus Rahman <crahman@gmail.com> AuthorDate: 2023-04-16 02:27:53 +0000 Commit: Kyle Evans <kevans@FreeBSD.org> CommitDate: 2023-04-16 02:39:52 +0000 loader: lua: unload the kernel when changing BEs Usually the kernel is loaded later, but there are circumstances where it could have been loaded earlier than changing BEs. Unload anything that is already there so that we know we're using artifacts from the proper environment. PR: 265471 Reviewed by: kevans MFC after: 3 days stand/lua/menu.lua | 3 +++ 1 file changed, 3 insertions(+)
Sorry for the delay, thanks for the patches! I'll MFC these to stable/13 within a week or so.
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=7e5811f76bb0df289b32144849331a2db83ac718 commit 7e5811f76bb0df289b32144849331a2db83ac718 Author: Cyrus Rahman <crahman@gmail.com> AuthorDate: 2023-04-16 02:27:53 +0000 Commit: Kyle Evans <kevans@FreeBSD.org> CommitDate: 2023-04-20 04:15:15 +0000 loader: lua: unload the kernel when changing BEs Usually the kernel is loaded later, but there are circumstances where it could have been loaded earlier than changing BEs. Unload anything that is already there so that we know we're using artifacts from the proper environment. PR: 265471 Reviewed by: kevans MFC after: 3 days (cherry picked from commit d7584aa09fcf8d96544e5bfb3ea78f50d7720c0c) stand/lua/menu.lua | 3 +++ 1 file changed, 3 insertions(+)
Thanks for the patch!