Attachment #170247 for bug #209154





PORTNAME=	zabbix24
PORTVERSION=	2.4.8
PORTREVISION?=	1
CATEGORIES=	net-mgmt
MASTER_SITES=	SF/zabbix/ZABBIX%20Latest%20Stable/${PORTVERSION}
PKGNAMESUFFIX?=	-server

	@${REINPLACE_CMD} -e 's#/usr/sbin/fping#${LOCALBASE}/sbin/fping#g' \
		${WRKSRC}/conf/zabbix_*.conf

.if ${ZABBIX_BUILD} == "server"
	@${REINPLACE_CMD} -e 's#PidFile=/tmp/zabbix_server.pid#PidFile=/var/run/zabbix/zabbix_server.pid#g' \
		${WRKSRC}/conf/zabbix_server*.conf
.endif

.if ${ZABBIX_BUILD} == "proxy"
	@${REINPLACE_CMD} -e 's#PidFile=/tmp/zabbix_proxy.pid#PidFile=/var/run/zabbix/zabbix_proxy.pid#g' \
		${WRKSRC}/conf/zabbix_proxy*.conf
.endif

.if ${ZABBIX_BUILD} == "agent"
	@${REINPLACE_CMD} -e 's#PidFile=/tmp/zabbix_agentd.pid#PidFile=/var/run/zabbix/zabbix_agentd.pid#g' \
		${WRKSRC}/conf/zabbix_agentd*.conf
.endif

.if ${ZABBIX_BUILD} != "agent"
.  for d in mysql oracle postgresql sqlite3
	@${REINPLACE_CMD} \

Line 0 Link Here

(-)zabbix24-server/files/patch-src-zabbix_agent_zabbix_agentd.c (+11 lines)
	1	--- src/zabbix_agent/zabbix_agentd.c.orig 2016-05-13 14:37:25.696606000 +0300
	2	+++ src/zabbix_agent/zabbix_agentd.c 2016-05-13 14:49:45.011554761 +0300
	3	@@ -521,7 +521,7 @@
	4	CONFIG_LOAD_MODULE_PATH = zbx_strdup(CONFIG_LOAD_MODULE_PATH, LIBDIR "/modules");
	5
	6	if (NULL == CONFIG_PID_FILE)
	7	- CONFIG_PID_FILE = "/tmp/zabbix_agentd.pid";
	8	+ CONFIG_PID_FILE = "/var/run/zabbix/zabbix_agentd.pid";
	9	#endif
	10	if (NULL == CONFIG_LOG_TYPE_STR)
	11	CONFIG_LOG_TYPE_STR = zbx_strdup(CONFIG_LOG_TYPE_STR, ZBX_OPTION_LOGTYPE_FILE);

Line 0 Link Here

(-)zabbix24-server/files/patch-src-zabbix_proxy_proxy.c (+11 lines)
	1	--- src/zabbix_proxy/proxy.c.orig 2016-04-20 12:51:20.000000000 +0300
	2	+++ src/zabbix_proxy/proxy.c 2016-05-13 14:46:44.193569184 +0300
	3	@@ -389,7 +389,7 @@
	4	CONFIG_SNMPTRAP_FILE = zbx_strdup(CONFIG_SNMPTRAP_FILE, "/tmp/zabbix_traps.tmp");
	5
	6	if (NULL == CONFIG_PID_FILE)
	7	- CONFIG_PID_FILE = zbx_strdup(CONFIG_PID_FILE, "/tmp/zabbix_proxy.pid");
	8	+ CONFIG_PID_FILE = zbx_strdup(CONFIG_PID_FILE, "/var/run/zabbix/zabbix_proxy.pid");
	9
	10	if (NULL == CONFIG_TMPDIR)
	11	CONFIG_TMPDIR = zbx_strdup(CONFIG_TMPDIR, "/tmp");

Line 0 Link Here

(-)zabbix24-server/files/patch-src-zabbix_server_server.c (+11 lines)
	1	--- src/zabbix_server/server.c.orig 2016-04-20 12:51:20.000000000 +0300
	2	+++ src/zabbix_server/server.c 2016-05-13 14:20:17.603677788 +0300
	3	@@ -369,7 +369,7 @@
	4	CONFIG_SNMPTRAP_FILE = zbx_strdup(CONFIG_SNMPTRAP_FILE, "/tmp/zabbix_traps.tmp");
	5
	6	if (NULL == CONFIG_PID_FILE)
	7	- CONFIG_PID_FILE = zbx_strdup(CONFIG_PID_FILE, "/tmp/zabbix_server.pid");
	8	+ CONFIG_PID_FILE = zbx_strdup(CONFIG_PID_FILE, "/var/run/zabbix/zabbix_server.pid");
	9
	10	if (NULL == CONFIG_ALERT_SCRIPTS_PATH)
	11	CONFIG_ALERT_SCRIPTS_PATH = zbx_strdup(CONFIG_ALERT_SCRIPTS_PATH, DATADIR "/zabbix/alertscripts");




#
# zabbix_agentd_enable (bool): Set to NO by default.  Set it to YES to
#         enable zabbix_agentd.
# zabbix_agentd_paths (string): Set to standard path by default.  Set a search
#         if you have custom userparams that need binaries elsewhere.
# zabbix_agentd_config (string): Set to the standard config file path by
#         default.
# zabbix_agentd_pidfile (string):    Location of the asterisk pid file
#                               Default is /var/run/zabbix/zabbix_agentd.pid
#

. /etc/rc.subr


load_rc_config $name

: ${zabbix_agentd_enable:=NO}
: ${zabbix_agentd_config:=%%ETCDIR%%/${name}.conf}
: ${zabbix_agentd_pidfile:=/var/run/zabbix/zabbix_agentd.pid}

command="%%PREFIX%%/sbin/${name}"
required_files="${zabbix_agentd_config}"
start_precmd="find_pidfile"
status_precmd="find_pidfile"
stop_precmd="find_pidfile"

start_precmd=zabbix_agentd_precmd 
status_precmd=zabbix_agentd_precmd
stop_precmd=zabbix_agentd_precmd

zabbix_agentd_precmd()
{
	if get_pidfile_from_conf PidFile ${zabbix_agentd_config}; then
		pidfile="$_pidfile_from_conf"
	else
		pidfile=${zabbix_agentd_pidfile}
		local rundir=${zabbix_agentd_pidfile%/*}
		if [ ! -d $rundir ] ; then
			install -d -m 0755 -o zabbix -g zabbix $rundir
		fi
	fi

	# This shouldn't be necessary with pidfile, but empirically it was the

	rc_pid=$(check_pidfile ${pidfile} ${command})
}

export PATH="${zabbix_agentd_paths}"

run_rc_command "$1"




#
# zabbix_proxy_enable (bool): Set to NO by default.  Set it to YES to
#         enable zabbix_proxy.
# zabbix_proxy_paths (string): Set to standard path by default.  Set a search
#         if you have custom externals that need binaries elsewhere.
# zabbix_proxy_config (string): Set to the standard config file path by
#         default.
# zabbix_proxy_pidfile (string):    Location of the asterisk pid file
#                               Default is /var/run/zabbix/zabbix_proxy.pid
#

. /etc/rc.subr


load_rc_config $name

: ${zabbix_proxy_enable:=NO}
: ${zabbix_proxy_config:=%%ETCDIR%%/${name}.conf}
: ${zabbix_proxy_pidfile:=/var/run/zabbix/zabbix_proxy.pid}

command="%%PREFIX%%/sbin/${name}"
required_files="${zabbix_proxy_config}"
start_precmd="find_pidfile"
status_precmd="find_pidfile"
stop_precmd="find_pidfile"

start_precmd=zabbix_proxy_precmd 
status_precmd=zabbix_proxy_precmd
stop_precmd=zabbix_proxy_precmd

zabbix_proxy_precmd()
{
	if get_pidfile_from_conf PidFile ${zabbix_proxy_config}; then
		pidfile="$_pidfile_from_conf"
	else
		pidfile=${zabbix_proxy_pidfile}
		local rundir=${zabbix_proxy_pidfile%/*}
		if [ ! -d $rundir ] ; then
			install -d -m 0755 -o zabbix -g zabbix $rundir
		fi
	fi

	# This shouldn't be necessary with pidfile, but empirically it was the

	rc_pid=$(check_pidfile ${pidfile} ${command})
}

export PATH="${zabbix_proxy_paths}"

run_rc_command "$1"




#
# zabbix_server_enable (bool): Set to NO by default.  Set it to YES to
#         enable zabbix_server.
# zabbix_server_paths (string): Set to standard path by default.  Set a search
#         if you have custom externals that need binaries elsewhere.
# zabbix_server_config (string): Set to the standard config file path by
#         default.
# zabbix_server_pidfile (string):    Location of the asterisk pid file
#                               Default is /var/run/zabbix/zabbix_server.pid
#

. /etc/rc.subr


load_rc_config $name

: ${zabbix_server_enable:=NO}
: ${zabbix_server_config:=%%ETCDIR%%/${name}.conf}
: ${zabbix_server_pidfile:=/var/run/zabbix/zabbix_server.pid}

command="%%PREFIX%%/sbin/${name}"
required_files="${zabbix_server_config}"
start_precmd="find_pidfile"
status_precmd="find_pidfile"
stop_precmd="find_pidfile"

start_precmd=zabbix_server_precmd 
status_precmd=zabbix_server_precmd
stop_precmd=zabbix_server_precmd

zabbix_server_precmd()
{
	if get_pidfile_from_conf PidFile ${zabbix_server_config}; then
		pidfile="$_pidfile_from_conf"
	else
		pidfile=${zabbix_server_pidfile}
		local rundir=${zabbix_server_pidfile%/*}
		if [ ! -d $rundir ] ; then
			install -d -m 0755 -o zabbix -g zabbix $rundir
		fi
	fi

	# This shouldn't be necessary with pidfile, but empirically it was the

	rc_pid=$(check_pidfile ${pidfile} ${command})
}

export PATH="${zabbix_server_paths}"

run_rc_command "$1"

Return to bug 209154

Lines 3-9 Link Here

(-)zabbix24-server/Makefile (-1 / +16 lines)
3		3
4	PORTNAME= zabbix24	4	PORTNAME= zabbix24
5	PORTVERSION= 2.4.8	5	PORTVERSION= 2.4.8
6	PORTREVISION?= 0	6	PORTREVISION?= 1
7	CATEGORIES= net-mgmt	7	CATEGORIES= net-mgmt
8	MASTER_SITES= SF/zabbix/ZABBIX%20Latest%20Stable/${PORTVERSION}	8	MASTER_SITES= SF/zabbix/ZABBIX%20Latest%20Stable/${PORTVERSION}
9	PKGNAMESUFFIX?= -server	9	PKGNAMESUFFIX?= -server
Lines 144-149 Link Here
144	@${REINPLACE_CMD} -e 's#/usr/sbin/fping#${LOCALBASE}/sbin/fping#g' \	144	@${REINPLACE_CMD} -e 's#/usr/sbin/fping#${LOCALBASE}/sbin/fping#g' \
145	${WRKSRC}/conf/zabbix_*.conf	145	${WRKSRC}/conf/zabbix_*.conf
146		146
		147	.if ${ZABBIX_BUILD} == "server"
		148	@${REINPLACE_CMD} -e 's#PidFile=/tmp/zabbix_server.pid#PidFile=/var/run/zabbix/zabbix_server.pid#g' \
		149	${WRKSRC}/conf/zabbix_server*.conf
		150	.endif
		151
		152	.if ${ZABBIX_BUILD} == "proxy"
		153	@${REINPLACE_CMD} -e 's#PidFile=/tmp/zabbix_proxy.pid#PidFile=/var/run/zabbix/zabbix_proxy.pid#g' \
		154	${WRKSRC}/conf/zabbix_proxy*.conf
		155	.endif
		156
		157	.if ${ZABBIX_BUILD} == "agent"
		158	@${REINPLACE_CMD} -e 's#PidFile=/tmp/zabbix_agentd.pid#PidFile=/var/run/zabbix/zabbix_agentd.pid#g' \
		159	${WRKSRC}/conf/zabbix_agentd*.conf
		160	.endif
		161
147	.if ${ZABBIX_BUILD} != "agent"	162	.if ${ZABBIX_BUILD} != "agent"
148	. for d in mysql oracle postgresql sqlite3	163	. for d in mysql oracle postgresql sqlite3
149	@${REINPLACE_CMD} \	164	@${REINPLACE_CMD} \

Lines 9-18 Link Here

(-)zabbix24-server/files/zabbix_agentd.in (-12 / +15 lines)
9	#	9	#
10	# zabbix_agentd_enable (bool): Set to NO by default. Set it to YES to	10	# zabbix_agentd_enable (bool): Set to NO by default. Set it to YES to
11	# enable zabbix_agentd.	11	# enable zabbix_agentd.
12	# zabbix_agentd_paths (string): Set to standard path by default. Set a search
13	# if you have custom userparams that need binaries elsewhere.
14	# zabbix_agentd_config (string): Set to the standard config file path by	12	# zabbix_agentd_config (string): Set to the standard config file path by
15	# default.	13	# default.
		14	# zabbix_agentd_pidfile (string): Location of the asterisk pid file
		15	# Default is /var/run/zabbix/zabbix_agentd.pid
16	#	16	#
17		17
18	. /etc/rc.subr	18	. /etc/rc.subr
Lines 22-43 Link Here
22		22
23	load_rc_config $name	23	load_rc_config $name
24		24
25	: ${zabbix_agentd_enable="NO"}	25	: ${zabbix_agentd_enable:=NO}
26	: ${zabbix_agentd_paths=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin}	26	: ${zabbix_agentd_config:=%%ETCDIR%%/${name}.conf}
27	: ${zabbix_agentd_config="%%ETCDIR%%/${name}.conf"}	27	: ${zabbix_agentd_pidfile:=/var/run/zabbix/zabbix_agentd.pid}
28		28
29	command="%%PREFIX%%/sbin/${name}"	29	command="%%PREFIX%%/sbin/${name}"
30	required_files="${zabbix_agentd_config}"	30	required_files="${zabbix_agentd_config}"
31	start_precmd="find_pidfile"
32	status_precmd="find_pidfile"
33	stop_precmd="find_pidfile"
34		31
35	find_pidfile()	32	start_precmd=zabbix_agentd_precmd
		33	status_precmd=zabbix_agentd_precmd
		34	stop_precmd=zabbix_agentd_precmd
		35
		36	zabbix_agentd_precmd()
36	{	37	{
37	if get_pidfile_from_conf PidFile ${zabbix_agentd_config}; then	38	if get_pidfile_from_conf PidFile ${zabbix_agentd_config}; then
38	pidfile="$_pidfile_from_conf"	39	pidfile="$_pidfile_from_conf"
39	else	40	else
40	pidfile="/tmp/${name}.pid"	41	pidfile=${zabbix_agentd_pidfile}
		42	local rundir=${zabbix_agentd_pidfile%/*}
		43	if [ ! -d $rundir ] ; then
		44	install -d -m 0755 -o zabbix -g zabbix $rundir
		45	fi
41	fi	46	fi
42		47
43	# This shouldn't be necessary with pidfile, but empirically it was the	48	# This shouldn't be necessary with pidfile, but empirically it was the
Lines 47-52 Link Here
47	rc_pid=$(check_pidfile ${pidfile} ${command})	52	rc_pid=$(check_pidfile ${pidfile} ${command})
48	}	53	}
49		54
50	export PATH="${zabbix_agentd_paths}"
51
52	run_rc_command "$1"	55	run_rc_command "$1"

Lines 11-20 Link Here

(-)zabbix24-server/files/zabbix_proxy.in (-11 / +15 lines)
11	#	11	#
12	# zabbix_proxy_enable (bool): Set to NO by default. Set it to YES to	12	# zabbix_proxy_enable (bool): Set to NO by default. Set it to YES to
13	# enable zabbix_proxy.	13	# enable zabbix_proxy.
14	# zabbix_proxy_paths (string): Set to standard path by default. Set a search
15	# if you have custom externals that need binaries elsewhere.
16	# zabbix_proxy_config (string): Set to the standard config file path by	14	# zabbix_proxy_config (string): Set to the standard config file path by
17	# default.	15	# default.
		16	# zabbix_proxy_pidfile (string): Location of the asterisk pid file
		17	# Default is /var/run/zabbix/zabbix_proxy.pid
18	#	18	#
19		19
20	. /etc/rc.subr	20	. /etc/rc.subr
Lines 24-44 Link Here
24		24
25	load_rc_config $name	25	load_rc_config $name
26		26
27	: ${zabbix_proxy_enable="NO"}	27	: ${zabbix_proxy_enable:=NO}
28	: ${zabbix_proxy_config="%%ETCDIR%%/${name}.conf"}	28	: ${zabbix_proxy_config:=%%ETCDIR%%/${name}.conf}
		29	: ${zabbix_proxy_pidfile:=/var/run/zabbix/zabbix_proxy.pid}
29		30
30	command="%%PREFIX%%/sbin/${name}"	31	command="%%PREFIX%%/sbin/${name}"
31	required_files="${zabbix_proxy_config}"	32	required_files="${zabbix_proxy_config}"
32	start_precmd="find_pidfile"
33	status_precmd="find_pidfile"
34	stop_precmd="find_pidfile"
35		33
36	find_pidfile()	34	start_precmd=zabbix_proxy_precmd
		35	status_precmd=zabbix_proxy_precmd
		36	stop_precmd=zabbix_proxy_precmd
		37
		38	zabbix_proxy_precmd()
37	{	39	{
38	if get_pidfile_from_conf PidFile ${zabbix_proxy_config}; then	40	if get_pidfile_from_conf PidFile ${zabbix_proxy_config}; then
39	pidfile="$_pidfile_from_conf"	41	pidfile="$_pidfile_from_conf"
40	else	42	else
41	pidfile="/tmp/${name}.pid"	43	pidfile=${zabbix_proxy_pidfile}
		44	local rundir=${zabbix_proxy_pidfile%/*}
		45	if [ ! -d $rundir ] ; then
		46	install -d -m 0755 -o zabbix -g zabbix $rundir
		47	fi
42	fi	48	fi
43		49
44	# This shouldn't be necessary with pidfile, but empirically it was the	50	# This shouldn't be necessary with pidfile, but empirically it was the
Lines 48-53 Link Here
48	rc_pid=$(check_pidfile ${pidfile} ${command})	54	rc_pid=$(check_pidfile ${pidfile} ${command})
49	}	55	}
50		56
51	export PATH="${zabbix_proxy_paths}"
52
53	run_rc_command "$1"	57	run_rc_command "$1"

Lines 11-20 Link Here

(-)zabbix24-server/files/zabbix_server.in (-12 / +15 lines)
11	#	11	#
12	# zabbix_server_enable (bool): Set to NO by default. Set it to YES to	12	# zabbix_server_enable (bool): Set to NO by default. Set it to YES to
13	# enable zabbix_server.	13	# enable zabbix_server.
14	# zabbix_server_paths (string): Set to standard path by default. Set a search
15	# if you have custom externals that need binaries elsewhere.
16	# zabbix_server_config (string): Set to the standard config file path by	14	# zabbix_server_config (string): Set to the standard config file path by
17	# default.	15	# default.
		16	# zabbix_server_pidfile (string): Location of the asterisk pid file
		17	# Default is /var/run/zabbix/zabbix_server.pid
18	#	18	#
19		19
20	. /etc/rc.subr	20	. /etc/rc.subr
Lines 24-45 Link Here
24		24
25	load_rc_config $name	25	load_rc_config $name
26		26
27	: ${zabbix_server_enable="NO"}	27	: ${zabbix_server_enable:=NO}
28	: ${zabbix_server_paths=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin}	28	: ${zabbix_server_config:=%%ETCDIR%%/${name}.conf}
29	: ${zabbix_server_config="%%ETCDIR%%/${name}.conf"}	29	: ${zabbix_server_pidfile:=/var/run/zabbix/zabbix_server.pid}
30		30
31	command="%%PREFIX%%/sbin/${name}"	31	command="%%PREFIX%%/sbin/${name}"
32	required_files="${zabbix_server_config}"	32	required_files="${zabbix_server_config}"
33	start_precmd="find_pidfile"
34	status_precmd="find_pidfile"
35	stop_precmd="find_pidfile"
36		33
37	find_pidfile()	34	start_precmd=zabbix_server_precmd
		35	status_precmd=zabbix_server_precmd
		36	stop_precmd=zabbix_server_precmd
		37
		38	zabbix_server_precmd()
38	{	39	{
39	if get_pidfile_from_conf PidFile ${zabbix_server_config}; then	40	if get_pidfile_from_conf PidFile ${zabbix_server_config}; then
40	pidfile="$_pidfile_from_conf"	41	pidfile="$_pidfile_from_conf"
41	else	42	else
42	pidfile="/tmp/${name}.pid"	43	pidfile=${zabbix_server_pidfile}
		44	local rundir=${zabbix_server_pidfile%/*}
		45	if [ ! -d $rundir ] ; then
		46	install -d -m 0755 -o zabbix -g zabbix $rundir
		47	fi
43	fi	48	fi
44		49
45	# This shouldn't be necessary with pidfile, but empirically it was the	50	# This shouldn't be necessary with pidfile, but empirically it was the
Lines 49-54 Link Here
49	rc_pid=$(check_pidfile ${pidfile} ${command})	54	rc_pid=$(check_pidfile ${pidfile} ${command})
50	}	55	}
51		56
52	export PATH="${zabbix_server_paths}"
53
54	run_rc_command "$1"	57	run_rc_command "$1"