Bug 209154 - net-mgmt/zabbix24-proxy: error in rc.d script
Summary: net-mgmt/zabbix24-proxy: error in rc.d script
Status: Closed DUPLICATE of bug 209892
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bartek Rutkowski
URL:
Keywords: easy, patch, patch-ready
: 209632 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-04-29 20:26 UTC by Rob Turner
Modified: 2016-06-03 13:17 UTC (History)
6 users (show)

See Also:
vlad-fbsd: maintainer-feedback+

Attachments
patch for zabbix3* (9.76 KB, patch)
2016-05-13 12:31 UTC, pg 		pg: maintainer-approval+
Details | Diff
patch for zabbix24* (9.51 KB, patch)
2016-05-13 13:11 UTC, pg 		pg: maintainer-approval+
Details | Diff
patch for zabbix22* (10.07 KB, patch)
2016-05-18 09:03 UTC, pg 		pg: maintainer-approval+
Details | Diff
patch for zabbix2-* (9.96 KB, patch)
2016-05-18 09:04 UTC, pg 		pg: maintainer-approval+
Details | Diff
patch for zabbix3* (10.14 KB, patch)
2016-05-18 10:12 UTC, pg 		pg: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Turner 2016-04-29 20:26:57 UTC 
Line 38 of /usr/local/etc/rc.d/zabbix_proxy is currently set to:

        if get_pidfile_from_conf PidFile ${zabbix_agentd_config}; then

Line 38 of /usr/local/etc/rc.d/zabbix_proxy should be set to:

        if get_pidfile_from_conf PidFile ${zabbix_proxy_config}; then

Looks like a typo but this broke existing Zabbix Proxy installations.  Thanks, Rob
Comment 2 Rob Turner 2016-04-29 20:42:20 UTC 
Original error observed:

: service zabbix_proxy start
/usr/local/etc/rc.d/zabbix_proxy: ERROR: USAGE: get_pidfile_from_conf string file (zabbix_proxy)
Comment 3 Tiago Ribeiro 2016-05-02 18:17:42 UTC 
Affect zabbix3-proxy too.
Comment 4 Remko Catersels 2016-05-04 14:07:17 UTC 
Also affects zabbix22-server:

  if get_pidfile_from_conf PidFile ${zabbix_agentd_config}; then

Which should be:

  if get_pidfile_from_conf PidFile ${zabbix_server_config}; then

Same for zabbix22-proxy and zabbix24-proxy:
  
  if get_pidfile_from_conf PidFile ${zabbix_agentd_config}; then


Oddly enough zabbix24-server is correct.
Comment 5 pg 2016-05-13 12:31:29 UTC 
Created attachment 170246 [details]
patch for zabbix3*

- changed rc.d script
- patch default PidFile
Comment 6 pg 2016-05-13 13:11:17 UTC 
Created attachment 170247 [details]
patch for zabbix24*

- changed rc.d script
- patch default PidFile
Comment 7 pg 2016-05-18 09:03:50 UTC 
Created attachment 170427 [details]
patch for zabbix22*

patch for zabbix22*

- changed rc.d script
- patch default PidFile
Comment 8 pg 2016-05-18 09:04:39 UTC 
Created attachment 170428 [details]
patch for zabbix2-*

patch for zabbix2-*

- changed rc.d script
- patch default PidFile
Comment 9 pg 2016-05-18 10:12:02 UTC 
Created attachment 170430 [details]
patch for zabbix3*

patch for zabbix3*

- changed rc.d script
- patch default PidFile
- fix checking version of OpenSSL
Comment 10 FuX 2016-05-19 10:11:01 UTC 
*** Bug 209632 has been marked as a duplicate of this bug. ***
Comment 11 ari 2016-05-23 07:00:11 UTC 
This is a pretty serious breakage. All versions of zabbix are broken for all people. Can we accelerate having this committed?
Comment 12 VK 2016-05-23 08:37:48 UTC 
Thanks for the patches. Maintainer, can you confirm that patched ports build and install fine?
Comment 13 VK 2016-05-23 08:41:03 UTC 
Maintainer responded.
Comment 14 pg 2016-05-23 08:51:01 UTC 
Hi,
This patches from maintainer and have flag "maintainer-approval+". On my test system ports build and install fine.
Comment 15 Bartek Rutkowski freebsd_committer freebsd_triage 2016-05-30 18:41:28 UTC 
The PR title suggests this is about the zabbix24-proxy it contains several patch files and its not clear what's what here. Can you please clarify what this PR is about, upload one single patch file to be tested and committed? Thanks!
Comment 16 pg 2016-05-30 20:26:39 UTC 
This patch solves similar problems in all ports of zabbix (fix default path to PID and fix rc.d scripts). It may be correct to log new PR for zabbix{2,22,24,3} with these patches?
Comment 17 Bartek Rutkowski freebsd_committer freebsd_triage 2016-05-31 10:40:12 UTC 
Yeah, I think PR per patch/port combination would be the proper way, unless this is something that has to be committed together. If you'll create those PR's I can take care of them.
Comment 18 pg 2016-05-31 14:27:32 UTC 
Ok,
PR: 209890, 209891, 209892, 209893

Please close this PR as dublicate as 209892
Comment 19 Bartek Rutkowski freebsd_committer freebsd_triage 2016-06-03 13:17:41 UTC 

*** This bug has been marked as a duplicate of bug 209892 ***