Attachment #194005 for bug #228752

View | Details | Raw Unified | Return to bug 228752
Collapse All | Expand All

Lines 2-7 Link Here

(-)Makefile (+1 lines)
2		2
3	PORTNAME= kmymoney	3	PORTNAME= kmymoney
4	PORTVERSION= 5.0.1	4	PORTVERSION= 5.0.1
		5	PORTREVISION= 1
5	CATEGORIES= finance kde	6	CATEGORIES= finance kde
6	MASTER_SITES= KDE/stable/${PORTNAME}/${PORTVERSION}/src	7	MASTER_SITES= KDE/stable/${PORTNAME}/${PORTVERSION}/src
7		8




Fix crash when adding a new schedule to scheduled transactions

--- kmymoney/dialogs/transactioneditor.cpp.orig	2018-04-17 02:57:53 UTC
+++ kmymoney/dialogs/transactioneditor.cpp
@@ -178,7 +178,7 @@ void TransactionEditor::setup(QWidgetList& tabOrderWid
 
   // remove all unused widgets and don't forget to remove them
   // from the tab order list as well
-  d->m_editWidgets.removeOrphans();
+  // d->m_editWidgets.removeOrphans();
   QWidgetList::iterator it_w;
   const QWidgetList editWidgets(d->m_editWidgets.values());
   for (it_w = tabOrderWidgets.begin(); it_w != tabOrderWidgets.end();) {




Fix crash when editing transactions
https://bugs.kde.org/show_bug.cgi?id=392735

--- kmymoney/widgets/qwidgetcontainer.cpp.orig	2018-03-18 15:55:30 UTC
+++ kmymoney/widgets/qwidgetcontainer.cpp
@@ -51,9 +51,10 @@ void QWidgetContainer::removeOrphans()
     if ((*it_w) && (*it_w)->parent())
       ++it_w;
     else {
-      delete(*it_w);
-      remove(it_w.key());
-      it_w = begin();
+      QWidget* const w = *it_w;
+      it_w = erase(it_w);
+      if (w)
+        w->deleteLater();
     }
   }
 }

Return to bug 228752

Lines 1-13 Link Here

(-)files/patch-kmymoney_dialogs_transactioneditor.cpp (-13 lines)
1	Fix crash when adding a new schedule to scheduled transactions
2
3	--- kmymoney/dialogs/transactioneditor.cpp.orig 2018-04-17 02:57:53 UTC
4	+++ kmymoney/dialogs/transactioneditor.cpp
5	@@ -178,7 +178,7 @@ void TransactionEditor::setup(QWidgetList& tabOrderWid
6
7	// remove all unused widgets and don't forget to remove them
8	// from the tab order list as well
9	- d->m_editWidgets.removeOrphans();
10	+ // d->m_editWidgets.removeOrphans();
11	QWidgetList::iterator it_w;
12	const QWidgetList editWidgets(d->m_editWidgets.values());
13	for (it_w = tabOrderWidgets.begin(); it_w != tabOrderWidgets.end();) {

Line 0 Link Here

(-)files/patch-kmymoney_widgets_qwidgetcontainer.cpp (+19 lines)
	1	Fix crash when editing transactions
	2	https://bugs.kde.org/show_bug.cgi?id=392735
	3
	4	--- kmymoney/widgets/qwidgetcontainer.cpp.orig 2018-03-18 15:55:30 UTC
	5	+++ kmymoney/widgets/qwidgetcontainer.cpp
	6	@@ -51,9 +51,10 @@ void QWidgetContainer::removeOrphans()
	7	if ((it_w) && (it_w)->parent())
	8	++it_w;
	9	else {
	10	- delete(*it_w);
	11	- remove(it_w.key());
	12	- it_w = begin();
	13	+ QWidget* const w = *it_w;
	14	+ it_w = erase(it_w);
	15	+ if (w)
	16	+ w->deleteLater();
	17	}
	18	}
	19	}