Added
Link Here
|
1 |
Regressed by: https://github.com/WebKit/WebKit/commit/11ccaf183fad |
2 |
|
3 |
GStreamer.cpp.o -c /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.34.0/Source/WebCore/p |
4 |
latform/graphics/gstreamer/MediaSampleGStreamer.cpp |
5 |
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.34.0/Source/WebCore/platform/graphics/gs |
6 |
treamer/MediaSampleGStreamer.cpp:220:12: error: call to implicitly-deleted copy constructor o |
7 |
f 'WebCore::PlatformSample' |
8 |
return sample; |
9 |
^~~~~~ |
10 |
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.34.0/Source/WebCore/platform/MediaSample |
11 |
.h:57:7: note: copy constructor of 'PlatformSample' is implicitly deleted because field 'samp |
12 |
le' has a deleted copy constructor |
13 |
} sample; |
14 |
^ |
15 |
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.34.0/Source/WebCore/platform/MediaSample |
16 |
.h:56:66: note: copy constructor of '' is implicitly deleted because variant field 'byteRange |
17 |
Sample' has a non-trivial copy constructor |
18 |
std::pair<MTPluginByteSourceRef, CMFormatDescriptionRef> byteRangeSample; |
19 |
^ |
20 |
1 error generated. |
21 |
|
22 |
diff --git Source/WTF/wtf/PlatformHave.h Source/WTF/wtf/PlatformHave.h |
23 |
index 4c5f1d2..e61e7fc 100644 |
24 |
--- Source/WTF/wtf/PlatformHave.h |
25 |
+++ Source/WTF/wtf/PlatformHave.h |
26 |
@@ -909,6 +909,12 @@ |
27 |
#endif |
28 |
#endif |
29 |
|
30 |
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 110300 |
31 |
+#if !defined(HAVE_MT_PLUGIN_SAMPLE_CURSOR_PLAYABLE_HORIZON) |
32 |
+#define HAVE_MT_PLUGIN_SAMPLE_CURSOR_PLAYABLE_HORIZON 1 |
33 |
+#endif |
34 |
+#endif |
35 |
+ |
36 |
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 110200) \ |
37 |
|| (PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 140400) |
38 |
#define HAVE_AVCONTENTKEYREQUEST_PENDING_PROTECTION_STATUS 1 |
39 |
diff --git Source/WebCore/page/RuntimeEnabledFeatures.h Source/WebCore/page/RuntimeEnabledFeatures.h |
40 |
index c97386f..6bb9794 100644 |
41 |
--- Source/WebCore/page/RuntimeEnabledFeatures.h |
42 |
+++ Source/WebCore/page/RuntimeEnabledFeatures.h |
43 |
@@ -243,6 +243,11 @@ public: |
44 |
void setDisableMediaExperiencePIDInheritance(bool isDisabled) { m_disableMediaExperiencePIDInheritance = isDisabled; } |
45 |
bool disableMediaExperiencePIDInheritance() const { return m_disableMediaExperiencePIDInheritance; } |
46 |
#endif |
47 |
+ |
48 |
+#if HAVE(MT_PLUGIN_FORMAT_READER) |
49 |
+ void setWebMFormatReaderEnabled(bool isEnabled) { m_webMFormatReaderEnabled = isEnabled; } |
50 |
+ bool webMFormatReaderEnabled() const { return m_webMFormatReaderEnabled; } |
51 |
+#endif |
52 |
|
53 |
#if ENABLE(VORBIS) |
54 |
WEBCORE_EXPORT void setVorbisDecoderEnabled(bool isEnabled); |
55 |
@@ -375,6 +380,10 @@ private: |
56 |
bool m_webMFormatReaderEnabled { false }; |
57 |
#endif |
58 |
|
59 |
+#if HAVE(MT_PLUGIN_FORMAT_READER) |
60 |
+ bool m_webMFormatReaderEnabled { false }; |
61 |
+#endif |
62 |
+ |
63 |
#if ENABLE(MEDIA_SOURCE) |
64 |
bool m_webMParserEnabled { false }; |
65 |
bool m_webMWebAudioEnabled { false }; |
66 |
diff --git Source/WebCore/platform/MediaSample.h Source/WebCore/platform/MediaSample.h |
67 |
index 0847b97..d34ba7f 100644 |
68 |
--- Source/WebCore/platform/MediaSample.h |
69 |
+++ Source/WebCore/platform/MediaSample.h |
70 |
@@ -34,8 +34,6 @@ |
71 |
|
72 |
typedef struct opaqueCMSampleBuffer *CMSampleBufferRef; |
73 |
typedef struct _GstSample GstSample; |
74 |
-typedef struct OpaqueMTPluginByteSource *MTPluginByteSourceRef; |
75 |
-typedef const struct opaqueCMFormatDescription *CMFormatDescriptionRef; |
76 |
|
77 |
namespace WebCore { |
78 |
|
79 |
@@ -47,13 +45,11 @@ struct PlatformSample { |
80 |
MockSampleBoxType, |
81 |
CMSampleBufferType, |
82 |
GStreamerSampleType, |
83 |
- ByteRangeSampleType, |
84 |
} type; |
85 |
union { |
86 |
MockSampleBox* mockSampleBox; |
87 |
CMSampleBufferRef cmSampleBuffer; |
88 |
GstSample* gstSample; |
89 |
- std::pair<MTPluginByteSourceRef, CMFormatDescriptionRef> byteRangeSample; |
90 |
} sample; |
91 |
}; |
92 |
|
93 |
@@ -91,12 +87,6 @@ public: |
94 |
virtual SampleFlags flags() const = 0; |
95 |
virtual PlatformSample platformSample() = 0; |
96 |
|
97 |
- struct ByteRange { |
98 |
- size_t byteOffset { 0 }; |
99 |
- size_t byteLength { 0 }; |
100 |
- }; |
101 |
- virtual std::optional<ByteRange> byteRange() const = 0; |
102 |
- |
103 |
enum class VideoRotation { |
104 |
None = 0, |
105 |
UpsideDown = 180, |
106 |
diff --git Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h |
107 |
index d7a49b9..874c3dc 100644 |
108 |
--- Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h |
109 |
+++ Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h |
110 |
@@ -57,7 +57,6 @@ public: |
111 |
Ref<MediaSample> createNonDisplayingCopy() const override; |
112 |
SampleFlags flags() const override { return m_flags; } |
113 |
PlatformSample platformSample() override; |
114 |
- std::optional<ByteRange> byteRange() const override { return std::nullopt; } |
115 |
void dump(PrintStream&) const override; |
116 |
RefPtr<JSC::Uint8ClampedArray> getRGBAImageData() const final; |
117 |
|
118 |
diff --git Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp |
119 |
index 5cb60b9..83da5b0 100644 |
120 |
--- Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp |
121 |
+++ Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp |
122 |
@@ -62,7 +62,6 @@ private: |
123 |
size_t sizeInBytes() const override { return sizeof(m_box); } |
124 |
SampleFlags flags() const override; |
125 |
PlatformSample platformSample() override; |
126 |
- std::optional<ByteRange> byteRange() const override { return std::nullopt; } |
127 |
FloatSize presentationSize() const override { return FloatSize(); } |
128 |
void dump(PrintStream&) const override; |
129 |
void offsetTimestampsBy(const MediaTime& offset) override { m_box.offsetTimestampsBy(offset); } |
130 |
diff --git Source/WebKit/MediaFormatReaderPlugIn/MediaFormatReaderPlugIn.cpp Source/WebKit/MediaFormatReaderPlugIn/MediaFormatReaderPlugIn.cpp |
131 |
index 496e42a..43664ed 100644 |
132 |
--- Source/WebKit/MediaFormatReaderPlugIn/MediaFormatReaderPlugIn.cpp |
133 |
+++ Source/WebKit/MediaFormatReaderPlugIn/MediaFormatReaderPlugIn.cpp |
134 |
@@ -23,14 +23,15 @@ |
135 |
* THE POSSIBILITY OF SUCH DAMAGE. |
136 |
*/ |
137 |
|
138 |
-#include <WebKit/WKMediaFormatReader.h> |
139 |
+#include "config.h" |
140 |
|
141 |
-extern "C" WK_EXPORT OSStatus CreateMediaFormatReaderInstance(MTPluginByteSourceRef, CFAllocatorRef, CFDictionaryRef, MTPluginFormatReaderRef*); |
142 |
+#if HAVE(MT_PLUGIN_FORMAT_READER) |
143 |
|
144 |
-OSStatus CreateMediaFormatReaderInstance(MTPluginByteSourceRef byteSource, CFAllocatorRef allocator, CFDictionaryRef, MTPluginFormatReaderRef* formatReader) |
145 |
+OSStatus CreateMediaFormatReaderInstance(MTPluginByteSourceRef, CFAllocatorRef, CFDictionary |
146 |
+Ref, MTPluginFormatReaderRef* formatReader) |
147 |
{ |
148 |
- OSStatus status = WKMediaFormatReaderCreate(allocator, formatReader); |
149 |
- if (status != noErr) |
150 |
- return status; |
151 |
- return WKMediaFormatReaderStartOnMainThread(*formatReader, byteSource); |
152 |
+ *formatReader = nullptr; |
153 |
+ return kMTPluginFormatReaderError_InternalFailure; |
154 |
} |
155 |
+ |
156 |
+#endif // HAVE(MT_PLUGIN_FORMAT_READER) |
157 |
diff --git Source/WebKit/Shared/WebPreferencesDefaultValues.cpp Source/WebKit/Shared/WebPreferencesDefaultValues.cpp |
158 |
index 8b24061..83e3a04 100644 |
159 |
--- Source/WebKit/Shared/WebPreferencesDefaultValues.cpp |
160 |
+++ Source/WebKit/Shared/WebPreferencesDefaultValues.cpp |
161 |
@@ -289,6 +289,19 @@ bool defaultWebMFormatReaderEnabled() |
162 |
|
163 |
#endif // ENABLE(WEBM_FORMAT_READER) |
164 |
|
165 |
+#if ENABLE(MEDIA_SOURCE) && HAVE(MT_PLUGIN_FORMAT_READER) |
166 |
+ |
167 |
+bool defaultWebMFormatReaderEnabled() |
168 |
+{ |
169 |
+#if HAVE(SYSTEM_FEATURE_FLAGS) |
170 |
+ return isFeatureFlagEnabled("webm_format_reader"); |
171 |
+#endif |
172 |
+ |
173 |
+ return false; |
174 |
+} |
175 |
+ |
176 |
+#endif |
177 |
+ |
178 |
#if ENABLE(VP9) |
179 |
|
180 |
bool defaultVP8DecoderEnabled() |
181 |
diff --git Source/WebKit/Shared/WebPreferencesDefaultValues.h Source/WebKit/Shared/WebPreferencesDefaultValues.h |
182 |
index c7af0cb..c1c91ed 100644 |
183 |
--- Source/WebKit/Shared/WebPreferencesDefaultValues.h |
184 |
+++ Source/WebKit/Shared/WebPreferencesDefaultValues.h |
185 |
@@ -95,6 +95,10 @@ bool defaultWebXREnabled(); |
186 |
bool defaultWebMFormatReaderEnabled(); |
187 |
#endif |
188 |
|
189 |
+#if ENABLE(MEDIA_SOURCE) && HAVE(MT_PLUGIN_FORMAT_READER) |
190 |
+bool defaultWebMFormatReaderEnabled(); |
191 |
+#endif |
192 |
+ |
193 |
#if ENABLE(VP9) |
194 |
bool defaultVP8DecoderEnabled(); |
195 |
bool defaultVP9DecoderEnabled(); |
196 |
diff --git Source/WebKit/SourcesCocoa.txt Source/WebKit/SourcesCocoa.txt |
197 |
index 78fb424..ac04aa8 100644 |
198 |
--- Source/WebKit/SourcesCocoa.txt |
199 |
+++ Source/WebKit/SourcesCocoa.txt |
200 |
@@ -229,6 +229,11 @@ Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp |
201 |
Shared/mac/MediaFormatReader/MediaSampleCursor.cpp |
202 |
Shared/mac/MediaFormatReader/MediaTrackReader.cpp |
203 |
|
204 |
+Shared/mac/MediaFormatReader/CoreMediaWrapped.cpp |
205 |
+Shared/mac/MediaFormatReader/FormatReader.cpp |
206 |
+Shared/mac/MediaFormatReader/SampleCursor.cpp |
207 |
+Shared/mac/MediaFormatReader/TrackReader.cpp |
208 |
+ |
209 |
Shared/Plugins/mac/PluginSandboxProfile.mm |
210 |
|
211 |
Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm |