Bug 255528 - www/webkit2-gtk3: update to 2.32.1
Summary: www/webkit2-gtk3: update to 2.32.1
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: needs-patch, needs-qa, security
Depends on:
Blocks:
 
Reported: 2021-05-01 11:07 UTC by Evgeniy Khramtsov
Modified: 2021-06-02 19:19 UTC (History)
2 users (show)

See Also:
vishwin: maintainer-feedback+


Attachments
patch (20.22 KB, patch)
2021-06-01 19:00 UTC, Evgeniy Khramtsov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evgeniy Khramtsov 2021-05-01 11:07:05 UTC
See https://webkitgtk.org/security/WSA-2021-0003.html
Comment 1 Evgeniy Khramtsov 2021-06-01 19:00:22 UTC
Created attachment 225472 [details]
patch

poudriere testport on 14-CURRENT and runtime with local ports tree fork: OK

Currently WIP (this was tested on one specific custom environment, pkg-plist wasn't tested with inverted options), waiting for the vanilla packages for 13.0-RELEASE to build (it is slow due to low power hardware), not using stuff from pkg.FreeBSD.org because it is not reproducible.

Could avoid using sysinfo, though way is less different from upstream sources.
Comment 2 Evgeniy Khramtsov 2021-06-01 19:00:57 UTC
And no VuXML for now, waiting for 13.0 packages and inverted options.
Comment 3 Evgeniy Khramtsov 2021-06-02 11:35:19 UTC
Vanilla build with GSTREAMER=on fails likely due to outdated gstreamer:

-std=c++17 -MD -MT Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/Media
SampleGStreamer.cpp.o -MF Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/M
ediaSampleGStreamer.cpp.o.d -o Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstrea
mer/MediaSampleGStreamer.cpp.o -c /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.32.1/S
ource/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.32.1/Source/WebCore/platform/graphics/gs
treamer/MediaSampleGStreamer.cpp:178:12: error: call to implicitly-deleted copy constructor o
f 'WebCore::PlatformSample'
    return sample;
           ^~~~~~
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.32.1/Source/WebCore/platform/MediaSample
.h:58:7: note: copy constructor of 'PlatformSample' is implicitly deleted because field 'samp
le' has a deleted copy constructor
    } sample;
      ^
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.32.1/Source/WebCore/platform/MediaSample
.h:57:66: note: copy constructor of '' is implicitly deleted because variant field 'byteRange
Sample' has a non-trivial copy constructor
        std::pair<MTPluginByteSourceRef, CMFormatDescriptionRef> byteRangeSample;
                                                                 ^
1 error generated.

multimedia/gstreamer1 is currently at 1.16.2 while repology reports 1.18.4 as the latest version. I'll try to update gstreamer, though that may be slow due to hardware.
Comment 4 Evgeniy Khramtsov 2021-06-02 18:30:55 UTC
(In reply to Evgeniy Khramtsov from comment #3)

This is not related to the gstreamer version, tried with locally updated gstreamer (every plugin in a single port, not upstreamable). USE_GCC=yes:build gets past that file, but then gcc segfaults (sig 11) just before the final linking. I am not an expert in C++ to fix this, and bruteforcing this problem would be too painful with slow compile times. gnome@ is free to continue, I think I helped you as I could.
Comment 5 Charlie Li freebsd_committer 2021-06-02 19:19:42 UTC
I have a WIP in my overlay that I partially built, but stopped due to limited CPU time. It involves a new (optional) dependency that the rest of GNOME 40 needs.