# https://git.alpinelinux.org/aports/log/community/exiv2

# https://github.com/Exiv2/exiv2/compare/v0.28.0...0.28.x

PATCH_SITES=	https://github.com/Exiv2/exiv2/commit/

PATCHFILES=	16c1cd7da0cd159ee2d53c39088564edaf046c77.patch:-p1 \

		2876c8c5f70f71b5b51b0f26b31dd0dc08583212.patch:-p1 \

		3664f5b826f5688b82470235d1dceef0c9c4c47d.patch:-p1 \

		b4f435a4ecceba0ef3a785dbe8eead6f55f49cc1.patch:-p1 \

		c5c4a54d4cf4ea544c30fe6780dab2755f404300.patch:-p1 \

		f47e7bd666aa063d016bdf00ea8f62c97a5b5a7a.patch:-p1

USE_LDCONFIG=	yes

SHEBANG_FILES=	fuzz/mkdictionary.py tests/runner.py

From aaa876159ada768ba0fb2d44b4eaaf23b3b2ed98 Mon Sep 17 00:00:00 2001

From: Matthias Andree <matthias.andree@gmx.de>

Date: Mon, 3 Jul 2023 11:16:44 +0200

Subject: [PATCH] Fix preprocessor warnings about undefined _MSVC_LANG

Stricter compiler/settings, such as found during a build

on FreeBSD with clang 14, issue warnings of the kind below.

/usr/local/include/exiv2/value.hpp:1272:31: warning: '_MSVC_LANG' is not defined, evaluates to 0 [-Wundef]

fixed-width font helps here-- ^

Fix: Guard use of _MSVC_LANG by a check.

Personally, I found that MSVC has several feature-specific

checks in predefined macros which might allow for one

standards-based check that matches GCC/clang/MSVC rather than the

split check for C++ standard and MSVC language version settings.

See https://en.cppreference.com/w/cpp/feature_test

I am not building Exiv2 on MSVC, so I cannot test/suggest

anything here.

--- include/exiv2/slice.hpp.orig	2023-05-08 16:01:13 UTC

+++ include/exiv2/slice.hpp

@@ -255,7 +255,7 @@ struct ContainerStorage {

   using iterator = typename container::iterator;

   using const_iterator = typename container::const_iterator;

-#if __cplusplus >= 201402L || _MSVC_LANG >= 201402L

+#if __cplusplus >= 201402L || (defined(_MSVC_LANG) && (_MSVC_LANG >= 201402L))

   using value_type = std::remove_cv_t<typename container::value_type>;

 #else

   using value_type = typename std::remove_cv<typename container::value_type>::type;

@@ -320,7 +320,7 @@ struct ContainerStorage {

  */

 template <typename storage_type>

 struct PtrSliceStorage {

-#if __cplusplus >= 201402L || _MSVC_LANG >= 201402L

+#if __cplusplus >= 201402L || (defined(_MSVC_LANG) && (_MSVC_LANG >= 201402L))

   using value_type = std::remove_cv_t<std::remove_pointer_t<storage_type>>;

 #else

   using value_type = typename std::remove_cv<typename std::remove_pointer<storage_type>::type>::type;

@@ -423,7 +423,7 @@ struct Slice : public Internal::MutableSliceBase<Inter

   using iterator = typename container::iterator;

   using const_iterator = typename container::const_iterator;

-#if __cplusplus >= 201402L || _MSVC_LANG >= 201402L

+#if __cplusplus >= 201402L || (defined(_MSVC_LANG) && (_MSVC_LANG >= 201402L))

   using value_type = std::remove_cv_t<typename container::value_type>;

 #else

   using value_type = typename std::remove_cv<typename container::value_type>::type;

@@ -460,7 +460,7 @@ struct Slice<const container> : public Internal::Const

   using iterator = typename container::iterator;

   using const_iterator = typename container::const_iterator;

-#if __cplusplus >= 201402L || _MSVC_LANG >= 201402L

+#if __cplusplus >= 201402L || (defined(_MSVC_LANG) && (_MSVC_LANG >= 201402L))

   using value_type = std::remove_cv_t<typename container::value_type>;

 #else

   using value_type = typename std::remove_cv<typename container::value_type>::type;

 include/exiv2/slice.hpp | 8 ++++----

 include/exiv2/value.hpp | 4 ++--

 2 files changed, 6 insertions(+), 6 deletions(-)

--- include/exiv2/value.hpp.orig	2023-05-08 16:01:13 UTC

+++ include/exiv2/value.hpp

@@ -1254,7 +1254,7 @@ class ValueType : public Value {

     } else if (std::is_signed<I>::value) {

 #endif

       // conversion is from unsigned to signed

-#if __cplusplus >= 201402L || _MSVC_LANG >= 201402L

+#if __cplusplus >= 201402L || (defined(_MSVC_LANG) && (_MSVC_LANG >= 201402L))

       const auto imax = static_cast<std::make_unsigned_t<I>>(std::numeric_limits<I>::max());

 #else

       const auto imax = static_cast<typename std::make_unsigned<I>::type>(std::numeric_limits<I>::max());

@@ -1269,7 +1269,7 @@ class ValueType : public Value {

         return 0;

       }

       // Inputs are not negative so convert them to unsigned.

-#if __cplusplus >= 201402L || _MSVC_LANG >= 201402L

+#if __cplusplus >= 201402L || (defined(_MSVC_LANG) && (_MSVC_LANG >= 201402L))

       const auto a_u = static_cast<std::make_unsigned_t<decltype(a)>>(a);

       const auto b_u = static_cast<std::make_unsigned_t<decltype(b)>>(b);

 #else

This patch fixes a crash when the procstat_getfiles()

return list contains non-vnodes that don't have an fs_path.

filed as https://github.com/Exiv2/exiv2/pull/2672

--- src/version.cpp.orig	2023-05-08 16:01:13 UTC

+++ src/version.cpp

@@ -148,7 +148,7 @@ static std::vector<std::string> getLoadedLibraries() {

     struct filestat_list* files = procs ? procstat_getfiles(procstat, procs, true) : nullptr;

     if (files) {

       filestat* entry;

-      STAILQ_FOREACH(entry, files, next) {

+      STAILQ_FOREACH(entry, files, next) if (entry && PS_FST_TYPE_VNODE == entry->fs_type && entry->fs_path) {

         std::string path(entry->fs_path);

         pushPath(path, libs, paths);

       }

XMP code is not dealing with format types properly. Cast argument to match format string.

filed as https://github.com/Exiv2/exiv2/pull/2671

--- xmpsdk/src/XMPMeta.cpp.orig	2023-05-08 16:01:13 UTC

+++ xmpsdk/src/XMPMeta.cpp

@@ -87,7 +87,7 @@ static const char * kTenSpaces = "          ";

 #define OutProcHexInt(num)	{ snprintf ( buffer, sizeof(buffer), "%X", (num) ); /* AUDIT: Using sizeof for snprintf length is safe */	\

 							  status = (*outProc) ( refCon, buffer, strlen(buffer) );  if ( status != 0 ) goto EXIT; }

 #else

-#define OutProcHexInt(num)	{ snprintf ( buffer, sizeof(buffer), "%lX", (num) ); /* AUDIT: Using sizeof for snprintf length is safe */	\

+#define OutProcHexInt(num)	{ snprintf ( buffer, sizeof(buffer), "%lX", (long)(num) ); /* AUDIT: Using sizeof for snprintf length is safe */	\

 							  status = (*outProc) ( refCon, buffer, strlen(buffer) );  if ( status != 0 ) goto EXIT; }

 #endif

XMP code is not dealing with format types properly.

Provide a variable that matches the format string to

avoid crashes when sizeof(long long) != sizeof(XMP_Int64).

filed as https://github.com/Exiv2/exiv2/pull/2671

--- xmpsdk/src/XMPUtils.cpp.orig	2023-05-08 16:01:13 UTC

+++ xmpsdk/src/XMPUtils.cpp

@@ -1215,7 +1215,7 @@ XMPUtils::ConvertToInt64 ( XMP_StringPtr strValue )

 	int count;

 	char nextCh;

-	XMP_Int64 result;

+	long long result;

 	if ( ! XMP_LitNMatch ( strValue, "0x", 2 ) ) {

 		count = sscanf ( strValue, "%lld%c", &result, &nextCh );

include/exiv2/photoshop.hpp