Attachment 173217 Details for Bug 211543 – Disambiguate `RRDs::graph @graph` as a function call

[patch] Disambiguate `RRDs::graph @graph` as a function call

smokeping.patch (text/plain), 3.25 KB, created by Matthew Seaman on 2016-08-03 11:18:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthew Seaman

Created: 2016-08-03 11:18:05 UTC

Size: 3.25 KB

patch

obsolete

>Index: files/patch-lib_Smokeping_Graphs.pm
>===================================================================
>--- files/patch-lib_Smokeping_Graphs.pm	(nonexistent)
>+++ files/patch-lib_Smokeping_Graphs.pm	(working copy)
>@@ -0,0 +1,11 @@
>+--- lib/Smokeping/Graphs.pm.orig	2011-10-05 09:51:46 UTC
>++++ lib/Smokeping/Graphs.pm
>+@@ -263,7 +263,7 @@ sub get_multi_detail ($$$$;$){
>+                'COMMENT:end\: '.$date.'\j';
>+ 
>+         my $graphret;
>+-        ($graphret,$xs,$ys) = RRDs::graph @task;
>++        ($graphret,$xs,$ys) = RRDs::graph(@task);
>+         #  print "<div>INFO:".join("<br/>",@task)."</div>";
>+         my $ERROR = RRDs::error();
>+         if ($ERROR) {
>
>Property changes on: files/patch-lib_Smokeping_Graphs.pm
>___________________________________________________________________
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property
>Index: files/patch-lib__Smokeping.pm
>===================================================================
>--- files/patch-lib__Smokeping.pm	(revision 419495)
>+++ files/patch-lib__Smokeping.pm	(working copy)
>@@ -1,6 +1,15 @@
>---- lib/Smokeping.pm.orig	2015-02-12 19:31:21.000000000 +0100
>-+++ lib/Smokeping.pm	2015-02-12 19:34:23.000000000 +0100
>-@@ -2632,12 +2632,14 @@
>+--- lib/Smokeping.pm.orig	2014-11-04 22:56:29 UTC
>++++ lib/Smokeping.pm
>+@@ -1413,7 +1413,7 @@ sub get_detail ($$$$;$){
>+ #       do_log ("***** end task ***** <br />");
>+                 
>+               my $graphret;
>+-              ($graphret,$xs{$s},$ys{$s}) = RRDs::graph @task;
>++              ($graphret,$xs{$s},$ys{$s}) = RRDs::graph(@task);
>+  #             die "<div>INFO:".join("<br/>",@task)."</div>";
>+               my $ERROR = RRDs::error();
>+               if ($ERROR) {
>+@@ -2632,12 +2632,14 @@ DOC
>          {
>           %$DIRCHECK_SUB,
>           _doc => <<DOC,
>@@ -19,7 +28,7 @@
>  DOC
>          },
>          piddir  =>
>-@@ -4214,7 +4216,7 @@
>+@@ -4214,7 +4216,7 @@ sub main (;$) {
>          if(defined $opt{'check'}) { verify_cfg($cfgfile); exit 0; }
>          if($opt{reload})  { 
>              load_cfg $cfgfile, 'noinit'; # we need just the piddir
>@@ -28,7 +37,7 @@
>              print "HUP signal sent to the running SmokePing process, exiting.\n";
>              exit 0;
>          };
>-@@ -4223,7 +4225,7 @@
>+@@ -4223,7 +4225,7 @@ sub main (;$) {
>          if(defined $opt{'static-pages'}) { makestaticpages $cfg, $opt{'static-pages'}; exit 0 };
>          if($opt{email})    { enable_dynamic $cfg, $cfg->{Targets},"",""; exit 0 };
>      }
>@@ -37,7 +46,7 @@
>  
>      if($opt{logfile})      { initialize_filelog($opt{logfile}) };
>  
>-@@ -4236,7 +4238,7 @@
>+@@ -4236,7 +4238,7 @@ sub main (;$) {
>                  initialize_syslog($cfg->{General}{syslogfacility}, 
>                                    $cfg->{General}{syslogpriority});
>          }
>@@ -46,7 +55,7 @@
>      }
>      do_log "Smokeping version $VERSION successfully launched.";
>  
>-@@ -4413,7 +4415,7 @@
>+@@ -4413,7 +4415,7 @@ KID:
>              my $new_conf = Smokeping::Slave::submit_results $slave_cfg,$cfg,$myprobe,$probes;
>              if ($new_conf && !$gothup){
>                  do_log('server has new config for me ... HUPing the parent');

Actions: View | Diff

Attachments on bug 211543: 173217