Bug 211543 - net-mgmt/smokeping fix build with perl-5.22
Summary: net-mgmt/smokeping fix build with perl-5.22
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-03 11:18 UTC by Matthew Seaman
Modified: 2016-08-10 13:50 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rodrigo)

Attachments
Disambiguate `RRDs::graph @graph` as a function call (3.25 KB, patch)
2016-08-03 11:18 UTC, Matthew Seaman 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Seaman freebsd_committer freebsd_triage 2016-08-03 11:18:05 UTC 
Created attachment 173217 [details]
Disambiguate `RRDs::graph @graph` as a function call

Building smokeping against perl-5.22.2 fails with a syntax error in lib/Smokeping/Graph.pm and lib/Smokeping.pm

```
(00:00:12) Array found where operator expected at ../lib/Smokeping/Graphs.pm line 266, near "RRDs::graph @task"
(00:00:12) 	(Do you need to predeclare RRDs::graph?)
(00:00:12) syntax error at ../lib/Smokeping/Graphs.pm line 266, near "RRDs::graph @task"
(00:00:12) Compilation failed in require at ../lib/Smokeping.pm line 22.
(00:00:12) BEGIN failed--compilation aborted at ../lib/Smokeping.pm line 22.
(00:00:12) Compilation failed in require.
(00:00:12) BEGIN failed--compilation aborted.
(00:00:12) Array found where operator expected at ../lib/Smokeping/Graphs.pm line 266, near "RRDs::graph @task"
(00:00:12) 	(Do you need to predeclare RRDs::graph?)
(00:00:12) Array found where operator expected at ../lib/Smokeping/Graphs.pm line 266, near "RRDs::graph @task"
```

Seems recent perl doesn't recognise `RRDs::graph @graph` as a function call.

Add some braces to disambiguate.  New file: patch-lib_Smokeping_Graphs.pm
Patches (re)generated by 'make makepatch'
Comment 1 Matthew Seaman freebsd_committer freebsd_triage 2016-08-03 11:18:50 UTC 
I'll submit this upstream too.
Comment 2 Matthew Seaman freebsd_committer freebsd_triage 2016-08-10 13:50:38 UTC 
Sorry.  This was PEBKAC.  smokeping needs rrdtool to be compiled with the GRAPHS option enabled.