Attachment 253419 Details for Bug 281358 – graphics/vigra: fix build with clang 19

[patch] graphics/vigra: fix build with clang 19

graphics__vigra-fix-clang19-build-1.diff (text/plain), 1.35 KB, created by Dimitry Andric on 2024-09-08 08:58:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitry Andric

Created: 2024-09-08 08:58:53 UTC

Size: 1.35 KB

patch

obsolete

>commit 3ceb417b0d253c97b5decf023621ab964db5db8c
>Author: Dimitry Andric <dim@FreeBSD.org>
>Date:   2024-09-08T10:57:41+02:00
>
>    graphics/vigra: fix build with clang 19
>    
>    Clang 19 is more strict about manipulating `this` in C++, which results
>    in an error compiling graphics/vigra:
>    
>        /wrkdirs/usr/ports/graphics/vigra/work/vigra-8acd73a/include/vigra/multi_iterator_coupled.hxx:493:9: error: expression is not assignable
>          493 |         --this;
>              |         ^ ~~~~
>    
>    Here, the intent is to call the prefix operator-- on the object, which
>    should be spelled either "--*this" or "operator--()".
>    
>    PR:             281358
>    MFH:            2024Q3
>
>diff --git a/graphics/vigra/files/patch-include_vigra_multi__iterator__coupled.hxx b/graphics/vigra/files/patch-include_vigra_multi__iterator__coupled.hxx
>new file mode 100644
>index 000000000000..b9bfe414615d
>--- /dev/null
>+++ b/graphics/vigra/files/patch-include_vigra_multi__iterator__coupled.hxx
>@@ -0,0 +1,11 @@
>+--- include/vigra/multi_iterator_coupled.hxx.orig	2018-10-19 16:12:20 UTC
>++++ include/vigra/multi_iterator_coupled.hxx
>+@@ -490,7 +490,7 @@ class CoupledScanOrderIterator<N, HANDLES, 0>
>+     CoupledScanOrderIterator operator--(int)
>+     {
>+         CoupledScanOrderIterator res(*this);
>+-        --this;
>++        --*this;
>+         return res;
>+     }
>+

Actions: View | Diff

Attachments on bug 281358: 253419