Bug 281358 - graphics/vigra: fix build with clang 19
Summary: graphics/vigra: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 280562
  Show dependency tree / graph
 
Reported: 2024-09-08 08:57 UTC by Dimitry Andric
Modified: 2024-09-28 09:51 UTC (History)
1 user (show)

See Also:

Attachments
graphics/vigra: fix build with clang 19 (1.35 KB, patch)
2024-09-08 08:58 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-09-08 08:57:13 UTC 
Clang 19 is more strict about manipulating `this` in C++, which results
in an error compiling graphics/vigra:

    /wrkdirs/usr/ports/graphics/vigra/work/vigra-8acd73a/include/vigra/multi_iterator_coupled.hxx:493:9: error: expression is not assignable
      493 |         --this;
          |         ^ ~~~~

Here, the intent is to call the prefix operator-- on the object, which
should be spelled either "--*this" or "operator--()".
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-09-08 08:58:53 UTC 
Created attachment 253419 [details]
graphics/vigra: fix build with clang 19
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-09-28 09:48:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a269b5cd4965710fa4e02fdb1cc2ffe6def6921

commit 5a269b5cd4965710fa4e02fdb1cc2ffe6def6921
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-09-08 08:57:41 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-09-28 09:42:56 +0000

    graphics/vigra: fix build with clang 19

    Clang 19 is more strict about manipulating `this` in C++, which results
    in an error compiling graphics/vigra:

        /wrkdirs/usr/ports/graphics/vigra/work/vigra-8acd73a/include/vigra/multi_iterator_coupled.hxx:493:9: error: expression is not assignable
          493 |         --this;
              |         ^ ~~~~

    Here, the intent is to call the prefix operator-- on the object, which
    should be spelled either "--*this" or "operator--()".

    PR:             281358
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q3

 .../patch-include_vigra_multi__iterator__coupled.hxx (new)    | 11 +++++++++++
 1 file changed, 11 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-28 09:49:20 UTC 
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ce0335c20a5dc0527b0ea764e1dcd8891b1026ea

commit ce0335c20a5dc0527b0ea764e1dcd8891b1026ea
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-09-08 08:57:41 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-09-28 09:48:23 +0000

    graphics/vigra: fix build with clang 19

    Clang 19 is more strict about manipulating `this` in C++, which results
    in an error compiling graphics/vigra:

        /wrkdirs/usr/ports/graphics/vigra/work/vigra-8acd73a/include/vigra/multi_iterator_coupled.hxx:493:9: error: expression is not assignable
          493 |         --this;
              |         ^ ~~~~

    Here, the intent is to call the prefix operator-- on the object, which
    should be spelled either "--*this" or "operator--()".

    PR:             281358
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q3

    (cherry picked from commit 5a269b5cd4965710fa4e02fdb1cc2ffe6def6921)

 .../patch-include_vigra_multi__iterator__coupled.hxx (new)    | 11 +++++++++++
 1 file changed, 11 insertions(+)