Attachment 255254 Details for Bug 282827 – math/libdivide: fix build with clang 19

[patch] math/libdivide: fix build with clang 19

math__libdivide-fix-clang19-build-1.diff (text/plain), 2.27 KB, created by Dimitry Andric on 2024-11-18 09:01:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitry Andric

Created: 2024-11-18 09:01:08 UTC

Size: 2.27 KB

patch

obsolete

>commit 944d6260974d1da74c1d1d61879ff0a593f89100
>Author: Dimitry Andric <dim@FreeBSD.org>
>Date:   2024-11-18T09:57:47+01:00
>
>    math/libdivide: fix build with clang 19
>    
>    Clang 19 has become more strict about errors in member functions, which
>    results in errors building math/libdivide:
>    
>      /wrkdirs/usr/ports/math/libdivide/work/libdivide-5.0/libdivide.h:3020:41: error: no member named 'denom' in 'divider<T, ALGO>'
>       3020 |         return div.denom.magic == other.denom.magic && div.denom.more == other.denom.more;
>            |                                   ~~~~~ ^
>      /wrkdirs/usr/ports/math/libdivide/work/libdivide-5.0/libdivide.h:3020:80: error: no member named 'denom' in 'divider<T, ALGO>'
>       3020 |         return div.denom.magic == other.denom.magic && div.denom.more == other.denom.more;
>            |                                                                          ~~~~~ ^
>    
>    The member function `operator==()` should refer to `other.div.denom`
>    instead. Upstream fixed this in
>    https://github.com/ridiculousfish/libdivide/commit/fa020f3, so import it
>    as a patch.
>    
>    PR:             282827
>    MFH:            2024Q4
>
>diff --git a/math/libdivide/Makefile b/math/libdivide/Makefile
>index 764f37805bd0..0a6fa1743e9e 100644
>--- a/math/libdivide/Makefile
>+++ b/math/libdivide/Makefile
>@@ -3,6 +3,9 @@ DISTVERSION=	5.0
> PORTREVISION=	1
> CATEGORIES=	math
> 
>+PATCH_SITES=	https://github.com/ridiculousfish/${PORTNAME}/commit/
>+PATCHFILES+=	fa020f3b3e7ab3e80a2b23ab70bad0f46dbab795.patch:-p1 # https://github.com/ridiculousfish/libdivide/pull/113
>+
> MAINTAINER=	thierry@FreeBSD.org
> COMMENT=	Fast prime counting function implementations
> WWW=		https://libdivide.com/
>diff --git a/math/libdivide/distinfo b/math/libdivide/distinfo
>index ac6777060bdd..50777c6cc211 100644
>--- a/math/libdivide/distinfo
>+++ b/math/libdivide/distinfo
>@@ -1,3 +1,5 @@
>-TIMESTAMP = 1638115355
>+TIMESTAMP = 1731919803
> SHA256 (ridiculousfish-libdivide-5.0_GH0.tar.gz) = 01ffdf90bc475e42170741d381eb9cfb631d9d7ddac7337368bcd80df8c98356
> SIZE (ridiculousfish-libdivide-5.0_GH0.tar.gz) = 680611
>+SHA256 (fa020f3b3e7ab3e80a2b23ab70bad0f46dbab795.patch) = 47ed962063ff09c4030a95297803e99b5899795bcaba7630fa3c5e0f80f583dd
>+SIZE (fa020f3b3e7ab3e80a2b23ab70bad0f46dbab795.patch) = 829

Actions: View | Diff

Attachments on bug 282827: 255254