Clang 19 has become more strict about errors in member functions, which results in errors building math/libdivide: /wrkdirs/usr/ports/math/libdivide/work/libdivide-5.0/libdivide.h:3020:41: error: no member named 'denom' in 'divider<T, ALGO>' 3020 | return div.denom.magic == other.denom.magic && div.denom.more == other.denom.more; | ~~~~~ ^ /wrkdirs/usr/ports/math/libdivide/work/libdivide-5.0/libdivide.h:3020:80: error: no member named 'denom' in 'divider<T, ALGO>' 3020 | return div.denom.magic == other.denom.magic && div.denom.more == other.denom.more; | ~~~~~ ^ The member function `operator==()` should refer to `other.div.denom` instead. Upstream fixed this in https://github.com/ridiculousfish/libdivide/commit/fa020f3, so import it as a patch.
Created attachment 255254 [details] math/libdivide: fix build with clang 19
Approved, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=822b0e7aebed327a924dc812b43c7cce2b19f7ea commit 822b0e7aebed327a924dc812b43c7cce2b19f7ea Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-11-18 08:57:47 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-11-18 22:51:34 +0000 math/libdivide: fix build with clang 19 Clang 19 has become more strict about errors in member functions, which results in errors building math/libdivide: /wrkdirs/usr/ports/math/libdivide/work/libdivide-5.0/libdivide.h:3020:41: error: no member named 'denom' in 'divider<T, ALGO>' 3020 | return div.denom.magic == other.denom.magic && div.denom.more == other.denom.more; | ~~~~~ ^ /wrkdirs/usr/ports/math/libdivide/work/libdivide-5.0/libdivide.h:3020:80: error: no member named 'denom' in 'divider<T, ALGO>' 3020 | return div.denom.magic == other.denom.magic && div.denom.more == other.denom.more; | ~~~~~ ^ The member function `operator==()` should refer to `other.div.denom` instead. Upstream fixed this in https://github.com/ridiculousfish/libdivide/commit/fa020f3, so import it as a patch. PR: 282827 Approved by: thierry (maintainer) MFH: 2024Q4 math/libdivide/Makefile | 3 +++ math/libdivide/distinfo | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)
A commit in branch 2024Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2216ea39e937ac6066e2ca788bd477193e05ab47 commit 2216ea39e937ac6066e2ca788bd477193e05ab47 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-11-18 08:57:47 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-11-18 22:52:33 +0000 math/libdivide: fix build with clang 19 Clang 19 has become more strict about errors in member functions, which results in errors building math/libdivide: /wrkdirs/usr/ports/math/libdivide/work/libdivide-5.0/libdivide.h:3020:41: error: no member named 'denom' in 'divider<T, ALGO>' 3020 | return div.denom.magic == other.denom.magic && div.denom.more == other.denom.more; | ~~~~~ ^ /wrkdirs/usr/ports/math/libdivide/work/libdivide-5.0/libdivide.h:3020:80: error: no member named 'denom' in 'divider<T, ALGO>' 3020 | return div.denom.magic == other.denom.magic && div.denom.more == other.denom.more; | ~~~~~ ^ The member function `operator==()` should refer to `other.div.denom` instead. Upstream fixed this in https://github.com/ridiculousfish/libdivide/commit/fa020f3, so import it as a patch. PR: 282827 Approved by: thierry (maintainer) MFH: 2024Q4 (cherry picked from commit 822b0e7aebed327a924dc812b43c7cce2b19f7ea) math/libdivide/Makefile | 3 +++ math/libdivide/distinfo | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)