Summary: | cannot compile editors/emacs after graphics/png upgrade | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | rotkap |
Component: | Individual Port(s) | Assignee: | Dirk Meyer <dinoex> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | ||
Priority: | Normal | ||
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
rotkap
2010-03-29 16:00:17 UTC
Maintainer of editors/emacs, Please note that PR ports/145171 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/145171 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Hello, The problem is known and fixed upstream, with a rather small patch: Initial patch: <http://repos.archlinux.org/wsvn/packages/emacs/trunk/libpng14.patch> emacs-devel, libpng 1.4.x, Herbert J. Skuhr & Chong Yidong: <http://lists.gnu.org/archive/html/emacs-devel/2010-01/msg01144.html> -- Fred Responsible Changed From-To: freebsd-ports-bugs->dinoex I will take care of it. Responsible Changed From-To: dinoex->closed Responsible Changed From-To: closed->dinoex - undo State Changed From-To: feedback->closed committed, thanks. Hello dinoex, I'm afraid the patch you committed is wrong: png_sig_cmp() is true when the signature does *not* correspond to that of a proper PNG file, so you shouldn't invert the result of png_sig_cmp(). Indeed, when opening a file that is a PNG, emacs no longer displays it. Would it be possible to use the patch that was installed upstream? Discussion about the proper fix: Re: libpng-1.4.x <http://lists.gnu.org/archive/html/emacs-devel/2010-01/msg01144.html> Chong Yidong & Herbert J. Skuhra. Upstream bzr commit: revno: 99377.1.36 committer: Chong Yidong <cyd (@) stupidchicken.com> branch nick: trunk timestamp: Sun 2010-01-24 18:03:13 -0500 (No direct HTTP link, with Savannah's broken loggerhead) Thanks, -- Fred dinoex 2010-03-30 18:15:38 UTC FreeBSD ports repository Modified files: editors/emacs Makefile editors/emacs/files patch-src-image.c editors/emacs-devel Makefile editors/emacs-devel/files patch-src-image.c editors/emacs22 Makefile editors/emacs22/files patch-src-image.c Log: - update patch png14 PR: 145171 Revision Changes Path 1.38 +1 -1 ports/editors/emacs-devel/Makefile 1.2 +2 -2 ports/editors/emacs-devel/files/patch-src-image.c 1.91 +1 -1 ports/editors/emacs/Makefile 1.3 +2 -2 ports/editors/emacs/files/patch-src-image.c 1.89 +1 -1 ports/editors/emacs22/Makefile 1.2 +2 -2 ports/editors/emacs22/files/patch-src-image.c _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" |